Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: v2.0 #317

Closed
snewcomer opened this issue Sep 11, 2018 · 1 comment
Closed

RFC: v2.0 #317

snewcomer opened this issue Sep 11, 2018 · 1 comment

Comments

@snewcomer
Copy link
Collaborator

snewcomer commented Sep 11, 2018

This issue is to track looking into and potentially removing the Relay implementation. I was not around when this was implemented but to the best of my knowledge, when trying to set a nested property/get a nested property, the Ember proxy is recursively called with each successive key.

GIven that we can't have native property accessors on the changeset (nor Ember.get(), this has cause considerable pain, especially has Ember core has moved to allowing native ES5 descriptor variant of get. See issues below. I have not found a way around this.

#315
#281

Action steps
I would advocate for a simpler model either removing the Relay implementation and/or involving native (polyfilled) Proxy in combination with https://github.com/poteto/ember-deep-set. It is hard to know what it looks like in the end until we play with it some more.

We have a nice suite of tests to fall back on for this refactor. However, I'm not sure all the edge cases unknownProperty helps us with, so that is the one outstanding item we need to be aware of.

Some Relay PR's.
#242
https://github.com/poteto/ember-changeset/pull/194/files

Ref #301 #245 #242

I will be really busy for the next month or so, but I'll see what I can dig into. If not much traction is gained/nobody else takes up this task, be sure it will be implemented by the end of October.

@snewcomer snewcomer self-assigned this Sep 11, 2018
@snewcomer snewcomer changed the title RFC: Remove Relay Implementation RFC: Remove Relay Implementation - target v2.0 Oct 19, 2018
@snewcomer snewcomer changed the title RFC: Remove Relay Implementation - target v2.0 RFC: v2.0 Oct 19, 2018
@snewcomer
Copy link
Collaborator Author

Just an update so far! `2.0-beta branch created

Pt. 1 merged into 2.0-beta branch.
#322

Pt. 2 a work in progress by @dorilla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant