Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres 17 support #44

Closed
wants to merge 1 commit into from
Closed

Postgres 17 support #44

wants to merge 1 commit into from

Conversation

aak74
Copy link

@aak74 aak74 commented Aug 28, 2024

  • #define ParallelLeaderProcNumber extracted from condition.
  • added package to control
  • updated dependencies

@rjuju
Copy link
Member

rjuju commented Aug 28, 2024

Hi,

Thanks for the PR. For the debian/ changes, at least the debian/control changes shouldn't be required. I'm not sure if the Build-depends is also really needed.

The ParallelLeaderProcNumber seems faulty? I just compiled the latest pg17 version and I get:

pg_stat_kcache.c: In function ‘pgsk_ExecutorEnd’:
pg_stat_kcache.c:101:34: error: ‘ParallelLeaderBackendId’ undeclared (first use in this function)
  101 | #define ParallelLeaderProcNumber ParallelLeaderBackendId
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
pg_stat_kcache.c:1091:50: note: in expansion of macro ‘ParallelLeaderProcNumber’
 1091 |                         queryId = pgsk->queryids[ParallelLeaderProcNumber];
      |                                                  ^~~~~~~~~~~~~~~~~~~~~~~~
pg_stat_kcache.c:101:34: note: each undeclared identifier is reported only once for each function it appears in
  101 | #define ParallelLeaderProcNumber ParallelLeaderBackendId
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
pg_stat_kcache.c:1091:50: note: in expansion of macro ‘ParallelLeaderProcNumber’
 1091 |                         queryId = pgsk->queryids[ParallelLeaderProcNumber];

The current code however compiles just fine and the regression tests also pass.

@aak74
Copy link
Author

aak74 commented Aug 29, 2024

Sorry for disturb.
I had used the wrong version of Postgres. The PR needs to be discarded.

@aak74 aak74 closed this Aug 29, 2024
@aak74 aak74 deleted the pg17-support branch August 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants