MySQL: Removed duplicate snapshot query stream invocation (#175)

Removed duplicate snapshot query stream invocation Added abort controller check during MySQL initial snapshot
powersync-ja · Jan 9, 2025 · 318f9f9 · 318f9f9
1 parent 715fc26
commit 318f9f9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/perfect-plums-cry.md b/.changeset/perfect-plums-cry.md
@@ -0,0 +1,5 @@
+---
+'@powersync/service-module-mysql': patch
+---
+
+Resolved excessive memory consumption during MySQL initial replication.
diff --git a/modules/module-mysql/src/replication/BinLogStream.ts b/modules/module-mysql/src/replication/BinLogStream.ts
@@ -305,12 +305,16 @@ AND table_type = 'BASE TABLE';`,
       columns = toColumnDescriptors(fields);
     });
 
-    for await (let row of query.stream()) {
+    for await (let row of stream) {
+      if (this.stopped) {
+        throw new Error('Abort signal received - initial replication interrupted.');
+      }
+
       if (columns == null) {
         throw new Error(`No 'fields' event emitted`);
       }
-      const record = common.toSQLiteRow(row, columns!);
 
+      const record = common.toSQLiteRow(row, columns!);
       await batch.save({
         tag: storage.SaveOperationTag.INSERT,
         sourceTable: table,