Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
stevensJourney committed Jan 29, 2025
1 parent 8cda6ff commit cc27649
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
8 changes: 7 additions & 1 deletion modules/module-postgres-storage/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,13 @@ storage:
```
**IMPORTANT**:
A separate Postgres server is currently required for replication connections (if using Postgres for replication) and storage. Using the same server might cause unexpected results.
A separate Postgres server is required for replication connections **if using PostgreSQL versions below 14**.
| PostgreSQL Version | Server configuration |
| ------------------ | --------------------------------------------------------------------------------------------------------------------------------------------- |
| Below 14 | Separate servers are required for the source and sync bucket storage. Using the same server on older versions might cause unexpected results. |
| 14 and above | The same server can be used for the source and sync bucket storage. Separate servers are also supported. |
### Connection credentials
Expand Down
4 changes: 2 additions & 2 deletions modules/module-postgres/test/src/storage_combination.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ describe.skipIf(!env.TEST_POSTGRES_STORAGE)('replication storage combination - p
await pool.query(`CREATE TABLE test_data(id text primary key, description text, other text)`);

if (sourceVersion!.compareMain('14.0.0') < 0) {
await expect(context.replicateSnapshot).rejects.toThrow();
await expect(context.replicateSnapshot()).rejects.toThrow();
} else {
await expect(context.replicateSnapshot).resolves.toReturn();
await expect(context.replicateSnapshot()).resolves.toReturn();

Check failure on line 31 in modules/module-postgres/test/src/storage_combination.test.ts

View workflow job for this annotation

GitHub Actions / Postgres Test (14)

test/src/storage_combination.test.ts > replication storage combination - postgres > should allow the same Postgres cluster to be used for data and storage

TypeError: undefined is not a spy or a call to a spy! ❯ test/src/storage_combination.test.ts:31:7

Check failure on line 31 in modules/module-postgres/test/src/storage_combination.test.ts

View workflow job for this annotation

GitHub Actions / Postgres Test (15)

test/src/storage_combination.test.ts > replication storage combination - postgres > should allow the same Postgres cluster to be used for data and storage

TypeError: undefined is not a spy or a call to a spy! ❯ test/src/storage_combination.test.ts:31:7

Check failure on line 31 in modules/module-postgres/test/src/storage_combination.test.ts

View workflow job for this annotation

GitHub Actions / Postgres Test (16)

test/src/storage_combination.test.ts > replication storage combination - postgres > should allow the same Postgres cluster to be used for data and storage

TypeError: undefined is not a spy or a call to a spy! ❯ test/src/storage_combination.test.ts:31:7
}
});
});

0 comments on commit cc27649

Please sign in to comment.