[Fix] Table change updates in write transactions #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
changed the title
Manrich121
reviewed
Jan 22, 2024
src/DBListenerManager.ts
Outdated
Comment on lines
48
to
49
| private _writeTransactionActive: boolean; | ||
| private updateBuffer: UpdateNotification[]; |
There was a problem hiding this comment.
nitpic: Use a consistent style for private members. (Personally using a _ prefix feels unnecessary, because we are accessing it with this.)
…es after write locks have completed or transaction has been committed.
1 task
rkistner
previously approved these changes
Jan 23, 2024
|
Automated tests are currently a bit broken. The Android emulator seems to be freezing at random intervals. Sometimes before tests begin and sometimes during tests. |
rkistner
approved these changes
Jan 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where table change updates registered via
registerUpdateHookwould trigger fromwriteTransactions before the changes have been committed or rolled back.If a client used the update hook to trigger a read from a read connection the updated data would not yet be visible. This causes inconsistent results when implementing watched queries.
This PR monitors the state of write transactions in order to emit update events only once the changes have been committed. This work is looseley based of the implementation here https://github.com/powersync-ja/sqlite_async.dart/blob/f994e165d5410c9ccca9a187de9c51fcedfd1182/lib/src/sqlite_connection_impl.dart#L310.
This PR also adds extra listeners which emit events for all table changes and write transaction events. This gives users access to table changes during transactions and allows for custom logic for deferring table change events during transactions.