[WIP] Tan phi generator extension #3146
Conversation
Signed-off-by: Sophie Frasnedo <[email protected]>
So-Fras
added
October 2024 release
December 2024 release
and removed
October 2024 release
labels
| /** | ||
| * @author Sophie Frasnedo {@literal <sophie.frasnedo at rte-france.com>} | ||
| */ | ||
| public interface GeneratorTanPhi extends Extension<Generator> { |
There was a problem hiding this comment.
@So-Fras are we sure tan phi is the correct and usual word in english ?
There was a problem hiding this comment.
Not at all! I don't like that name either and I hope to find a better alternative.
There was a problem hiding this comment.
CIM defines cim:RegulatingControlModeKind.powerFactor, I would suggest GeneratorPowerFactorRegulation.
but beware that powerFactor is cosPhi, not tanPhi
There was a problem hiding this comment.
So there is no standard term for tanPhi? Any if modelling using cos phi instead of tan phi is the standard way we should also use it, this is equivalent.
There was a problem hiding this comment.
Ok thanks for your feedback @geofjamg and @jeandemanged !
We would define a powerFactor parameter and then do a tan(acos(powerFactor)) to get what we need?
Should we allow the whole [-1; 1] range for cosPhi? In practice, it should always be close to 1, right?
I am not sure how the extension would be populated... By hand? We should think of a method to make it user-friendly for users who have the Q/P ratio in mind rather than the P/S one.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: