Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bus state for AC calculations #1058

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Fix bus state for AC calculations #1058

merged 3 commits into from
Jul 4, 2024

Conversation

annetill
Copy link
Member

@annetill annetill commented Jul 4, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No, regression in integration tests.

What kind of change does this PR introduce?

The q limit type of a bus is restored to null.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Anne Tilloy <[email protected]>
@annetill annetill requested a review from geofjamg July 4, 2024 05:51
@annetill annetill added bug Something isn't working PR: next-release labels Jul 4, 2024
annetill and others added 2 commits July 4, 2024 09:11
Copy link

sonarqubecloud bot commented Jul 4, 2024

@geofjamg geofjamg merged commit 1a6512f into main Jul 4, 2024
7 checks passed
@geofjamg geofjamg deleted the fix_bus_state branch July 4, 2024 10:21
olperr1 pushed a commit that referenced this pull request Jul 8, 2024
Signed-off-by: Anne Tilloy <[email protected]>
(cherry picked from commit 1a6512f)
flo-dup pushed a commit that referenced this pull request Jul 16, 2024
Signed-off-by: Anne Tilloy <[email protected]>
(cherry picked from commit 1a6512f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: next-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants