Refactor dc sensivity analysis #217
Conversation
flo-dup
changed the title
flo-dup
force-pushed
the
refactor_dcsa
branch
from
abb0902 to
0693e4e
Compare
flo-dup
force-pushed
the
refactor_dcsa
branch
2 times, most recently
from
1808991 to
6159cae
Compare
There was a problem hiding this comment.
I haven't checked the implementation of the new methods in the connectivity API, but I trust you
The refactoring looks really great ! I hope that at some point, we may have another way of computing "predefinedResults" than using component numbers within the Sensitivity Analysis, but this would be for another time.
| activePowerDistribution.run(buses, mismatch); | ||
| } | ||
|
|
||
| public static double getActivePowerMismatch(Collection<LfBus> buses) { |
There was a problem hiding this comment.
I don't like the idea of having as argument a list of buses because before it was a network that represents a unique synchronous component and now you hide that. Do you have to protect/private the functions that use this list as argument.
flo-dup
changed the title
Thanks, I just forgot that point! I think I can improve this a bit at least. |
| bus.setV(Double.NaN); | ||
| } | ||
| if (!removedBuses.isEmpty()) { | ||
| // set buses injections and transformers to 0 |
There was a problem hiding this comment.
Losing a transformer in a contingency requires us to do
equationSystem.getEquation(transformer.getNum(), EquationType.BRANCH_ALPHA1).get().getColumn() and set the value for this column to 0.
So we may also need to pass a list of removedTransformers
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]> Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor
What is the current behavior? (You can also link to an open issue here)
Does this PR introduce a breaking change or deprecate an API?
No