Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize DC performances #239

Merged
merged 14 commits into from
Mar 24, 2021
Merged

Optimize DC performances #239

merged 14 commits into from
Mar 24, 2021

Conversation

Djazouli
Copy link
Contributor

@Djazouli Djazouli commented Mar 9, 2021

Signed-off-by: Gael Macherel [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Djazouli added 4 commits March 9, 2021 19:31
Signed-off-by: Gael Macherel <[email protected]>
…y branch that really breaks connectivity

Signed-off-by: Gael Macherel <[email protected]>
Signed-off-by: Gael Macherel <[email protected]>
@Djazouli Djazouli changed the title [WIP] recompute rhs only if needed [WIP] Optimize DC performances Mar 10, 2021
…avior in the fillRhs function

Signed-off-by: Gael Macherel <[email protected]>
@annetill annetill changed the title [WIP] Optimize DC performances Optimize DC performances Mar 12, 2021
@annetill annetill requested review from geofjamg and flo-dup and removed request for geofjamg March 17, 2021 10:14
@geofjamg geofjamg mentioned this pull request Mar 21, 2021
5 tasks
@@ -102,6 +102,40 @@ protected JacobianMatrix createJacobianMatrix(EquationSystem equationSystem, Vol
return new JacobianMatrix(equationSystem, matrixFactory);
}

static class CachedBus {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not necessary anymore with #248 ?

Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my side and I think that the code, even if complex, is a bit more readable.

@annetill annetill requested a review from geofjamg March 24, 2021 11:49
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.9% 93.9% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 575d2b8 into master Mar 24, 2021
@geofjamg geofjamg deleted the dc_perf_optimization branch March 24, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants