Remove variable activation #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
@annetill @floriand-e2r this is the comeback a change I revert in the network listener PR :-). I added a description/explanation of the change in the PR, tell me if it is clear or not. |
flo-dup
approved these changes
Mar 22, 2021
Signed-off-by: Anne Tilloy <[email protected]>
# Conflicts: # src/main/java/com/powsybl/openloadflow/dc/equations/ClosedBranchSide1DcFlowEquationTerm.java # src/main/java/com/powsybl/openloadflow/dc/equations/ClosedBranchSide2DcFlowEquationTerm.java
Signed-off-by: Anne Tilloy <[email protected]>
annetill
approved these changes
Mar 23, 2021
|
Kudos, SonarCloud Quality Gate passed! |
annetill
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Variable has a active property which allows a variable considered either as a variable or as a constant in an equation term. The problem is that it is not fully implemented (see the ugly FIXME in Variable.java). By luck when we change the active status of a variable, we always also change the active status of its term, so it works but this is really fragile...
What is the new behavior (if this is a feature change)?
That would be hard to support a robust variable active status. Instead it is simpler to just rework the equation design by just adding a new equation v = constant when we want the variable to become constant.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)