Remote reactive power control support #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrix
changed the title
obrix
force-pushed
the
regulationMode_rework
branch
from
c87abcf to
dc481b8
Compare
annetill
reviewed
Apr 16, 2021
| return targetValue; | ||
| } | ||
|
|
||
| public LfBus getControlledBus() { |
There was a problem hiding this comment.
You should have a getControlledBranch.
There was a problem hiding this comment.
Yes this is still basically a copy of VoltageControl class. I will update that with the new information you have given me regarding DiscretePhaseControl class.
obrix
force-pushed
the
regulationMode_rework
branch
from
1be58df to
de092d4
Compare
annetill
reviewed
Apr 30, 2021
src/main/java/com/powsybl/openloadflow/util/ParameterConstants.java
Outdated
Show resolved
Hide resolved
obrix
force-pushed
the
regulationMode_rework
branch
from
d95a785 to
13b2173
Compare
…t by SetVoltageSetpoint. Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
…faithful to what is implemented. Also rename the associated test. Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Hadrien <[email protected]>
… control whether reactivePowerRemoteControl is enabled or not. It is enabled by default. Signed-off-by: Bertrand Rix <[email protected]>
…to add remoteReactive power equation terms. Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Hadrien <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
Signed-off-by: Bertrand Rix <[email protected]>
obrix
force-pushed
the
regulationMode_rework
branch
from
47f553d to
77cfd3b
Compare
annetill
changed the title
annetill
changed the title
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
geofjamg
requested changes
Sep 14, 2021
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfGenerator.java
Outdated
Show resolved
Hide resolved
| @@ -45,6 +45,9 @@ private static void createBusEquations(LfNetwork network, VariableSet<AcVariable | |||
| createDiscreteVoltageControlEquation(bus, variableSet, equationSystem); | |||
| } | |||
| Equation<AcVariableType, AcEquationType> v = equationSystem.createEquation(bus.getNum(), AcEquationType.BUS_V); | |||
| if (creationParameters.isReactivePowerControl()) { | |||
There was a problem hiding this comment.
Same concern with this, it it kind of hack that is done after createVoltageControlEquations. We could have a single place to configure control coming from generators.
There was a problem hiding this comment.
I'm not sure I understood properly what you expected @geofjamg: I put this reactive power control code in a createGeneratorControlEquations method, together with the content of createVoltageControlEquations, using the fact that on LfBus it is also either voltage control or reactive power control
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
For both voltage control and remote reactive power control Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Useless as reactivePowerControl not created if parameter false Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
approved these changes
Sep 16, 2021
Signed-off-by: Florian Dupuy <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Issue: #111
The goal of this PR is to introduce a new regulation mode based on remote reactive power.
It also use the new regulation mode for generator to be introduced in powsybl-core (Seen here )
What is the new behavior (if this is a feature change)?
TBD
Does this PR introduce a breaking change or deprecate an API? If yes, check the following: