Handle all connected components of a network #295

obrix · 2021-04-29T07:14:49Z

Try handling all the connected components in a network when building a LfNetwork and executing a loadflow.

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Introduce a boolean value in the network loader to chose to load only the main connected component of a network, or all connected components.

What is the current behavior? (You can also link to an open issue here)

Only the main connected component was loaded.

What is the new behavior (if this is a feature change)?

All connected components can now be loaded.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

…a LfNetwork and executing a loadflow. Signed-off-by: Bertrand Rix <[email protected]>

geofjamg

This feature should be configurable (OpenLoadFlowParameters)

obrix · 2021-04-29T07:55:58Z

@geofjamg Yes, what should be the default behavior ? Loading all connected components or only the main one ?

annetill · 2021-04-29T07:57:15Z

Only the main one.

…it a part of LfNetworkParameters. Signed-off-by: Bertrand Rix <[email protected]>

…DefaultOpenLoadflowConfig. Signed-off-by: Bertrand Rix <[email protected]>

Signed-off-by: Bertrand Rix <[email protected]>

annetill

You need to add tests for sure, for simple load flows but also for secruity analysis and sensitivity analysis. I am not sure the code is robust enough because sometimes we just take the first synchronous component of the main connected component and we want to keep that. @geofjamg do you agree?

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java

src/main/java/com/powsybl/openloadflow/sensi/AcSensitivityAnalysis.java

annetill · 2021-04-29T09:23:09Z

src/main/java/com/powsybl/openloadflow/dc/DcLoadFlowEngine.java

@@ -42,7 +42,9 @@ public DcLoadFlowEngine(LfNetwork network, MatrixFactory matrixFactory, boolean
    }

    public DcLoadFlowEngine(Object network, DcLoadFlowParameters parameters, Reporter reporter) {
-        LfNetworkParameters lfNetworkParameters = new LfNetworkParameters(parameters.getSlackBusSelector(), false, false, false, false, parameters.getPlausibleActivePowerLimit(), false);
+        LfNetworkParameters lfNetworkParameters = new LfNetworkParameters(parameters.getSlackBusSelector(), false, false, false, false,


Be careful here as we have in the code a LfNetwork network = networks.get(0); that says that we only deal with the first synchronous component. Do we want to do better here? Handle several synchronous components? Handle several connected components?

Yes, I made some changes in the code : I replaced all the get(0) I could find in the code by the use of a filter on the network num on what is defined as the "main num". I use the constant parameter ComponentConstants.MAIN_NUM provided by the core for that.
This is just a begining while waiting to see what we do with several connected components more largely.

annetill · 2021-04-29T09:23:21Z

src/main/java/com/powsybl/openloadflow/dc/DcLoadFlowParameters.java

    public DcLoadFlowParameters(SlackBusSelector slackBusSelector, MatrixFactory matrixFactory, boolean setVToNan) {
        this(slackBusSelector, matrixFactory, false, true, false, LoadFlowParameters.BalanceType.PROPORTIONAL_TO_GENERATION_P_MAX, false,
-                ParameterConstants.PLAUSIBLE_ACTIVE_POWER_LIMIT_DEFAULT_VALUE, false, setVToNan);
+                ParameterConstants.PLAUSIBLE_ACTIVE_POWER_LIMIT_DEFAULT_VALUE, false, setVToNan, ParameterConstants.LOAD_MAIN_CONNECTED_COMPONENT_ONLY_DEFAULT_VALUE);


src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java

…ntOnly to be more user friendly. Signed-off-by: Bertrand Rix <[email protected]>

…vity analysis. Signed-off-by: Bertrand Rix <[email protected]>

…twork instead of get(0). Signed-off-by: Bertrand Rix <[email protected]>

… not exist. Signed-off-by: Bertrand Rix <[email protected]>

Signed-off-by: Bertrand Rix <[email protected]>

…is only handling the main CC. Signed-off-by: Bertrand Rix <[email protected]>

…rk. Update testMultipleConnectedComponentsDCAllComponents test. Signed-off-by: Bertrand Rix <[email protected]>

Signed-off-by: Bertrand Rix <[email protected]>

annetill · 2021-04-30T11:49:51Z

src/main/java/com/powsybl/openloadflow/dc/DcLoadFlowEngine.java

@@ -68,10 +72,17 @@ private static double getActivePowerMismatch(Collection<LfBus> buses) {

    public DcLoadFlowResult run(Reporter reporter) {
        // only process main (largest) connected component
-        LfNetwork network = networks.get(0);
+        LfNetwork network = networks.stream().filter(n -> n.getNum() == ComponentConstants.MAIN_NUM).findAny().orElseThrow();


I need the main synchronous component here.

Can you create a method for that?

After our discussion : on lfNetwork I will use the existing connected component num and store the synchronous component num at loading, I will then update all filter I added to filter on CC num and SC num with MAIN_NUM value instead of just filter on CC num.

…onent filter. Signed-off-by: Bertrand Rix <[email protected]>

…network. Just test the computation is ok, only the main cc is computed. Signed-off-by: Bertrand Rix <[email protected]>

annetill · 2021-04-30T16:06:20Z

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java

        this.slackBusSelector = Objects.requireNonNull(slackBusSelector);
    }

-    public int getNum() {
-        return num;
+    public int getNumCC() {


Sorry for this, I know that you are close to become totally crazy but... you are right, we need both NumCC and NumSC, but from now when you want to log or store results linked to a LfNetwork, you really have to put the pair and not just NumCC. It will lead to change a bit some logs to be clear. But the big change will be in powsybl-core because the object LoadFlowResult only has one getComponentNum(). So it means that if you want to serenely finish this PR, you have to create a new feature in powsybl-core (so a new PR).

Signed-off-by: Bertrand Rix <[email protected]>

geofjamg · 2021-05-17T20:38:54Z

src/test/java/com/powsybl/openloadflow/OperationalLimitsTest.java

@@ -47,7 +48,7 @@ void testLineCurrentLimits() {
        Network network = EurostagTutorialExample1Factory.createWithFixedCurrentLimits();
        List<LfNetwork> lfNetworks = LfNetwork.load(network, new MostMeshedSlackBusSelector());
        assertEquals(1, lfNetworks.size());
-        LfNetwork lfNetwork = lfNetworks.get(0);
+        LfNetwork lfNetwork = lfNetworks.stream().filter(n -> n.getNumCC() == ComponentConstants.MAIN_NUM && n.getNumSC() == ComponentConstants.MAIN_NUM).findAny().orElseThrow();


These is boiler plate code. We have it everywhere in unit tests. Either we move it to a utility class of better we can just rely on the fact that first network is always the (main, main) one.

Signed-off-by: Florian Dupuy <[email protected]>

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Florian Dupuy <[email protected]>

src/main/java/com/powsybl/openloadflow/ac/outerloop/AcloadFlowEngine.java

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

Signed-off-by: Florian Dupuy <[email protected]>

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java

Signed-off-by: Florian Dupuy <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

sonarqubecloud · 2021-05-20T11:37:20Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

93.3% Coverage
0.0% Duplication

annetill

Thanks a lot @obrix and @flo-dup for this feature more complex to handle than expected!

Try handling all the connected components in a network when building …

208a4c2

…a LfNetwork and executing a loadflow. Signed-off-by: Bertrand Rix <[email protected]>

obrix requested a review from annetill April 29, 2021 07:44

geofjamg requested changes Apr 29, 2021

View reviewed changes

obrix added 3 commits April 29, 2021 10:49

Make connected component network parameter parametrisable. Also make …

ef28291

…it a part of LfNetworkParameters. Signed-off-by: Bertrand Rix <[email protected]>

Add test for LOAD_MAIN_CONNECTED_COMPONENT_ONLY_DEFAULT_VALUE in test…

b78e9c2

…DefaultOpenLoadflowConfig. Signed-off-by: Bertrand Rix <[email protected]>

Fix testDebug.

5f2e06b

Signed-off-by: Bertrand Rix <[email protected]>

annetill requested changes Apr 29, 2021

View reviewed changes

obrix added 10 commits April 29, 2021 14:17

Replace loadMainConnectedComponentOnly by computeMainConnectedCompone…

1c1f3b0

…ntOnly to be more user friendly. Signed-off-by: Bertrand Rix <[email protected]>

Foce usage of the main connected component only for Ac and Dc sensiti…

bfe092f

…vity analysis. Signed-off-by: Bertrand Rix <[email protected]>

Use constant MAIN_NUM to query the main connected component of the ne…

f680d8c

…twork instead of get(0). Signed-off-by: Bertrand Rix <[email protected]>

Throw instead of returning null when network with num = main_num does…

e83a1c9

… not exist. Signed-off-by: Bertrand Rix <[email protected]>

Add test in AC and DC on a simple network with two connected components.

d9ab6e3

Signed-off-by: Bertrand Rix <[email protected]>

Fix style.

725d66f

Signed-off-by: Bertrand Rix <[email protected]>

Fix code smells on asserts.

f8eaf19

Signed-off-by: Bertrand Rix <[email protected]>

Set ComputeMainConnectedComponentOnly to false to illustrate that DC …

c192efe

…is only handling the main CC. Signed-off-by: Bertrand Rix <[email protected]>

DC mode : launch a load flow on all connected components of the netwo…

eac9b28

…rk. Update testMultipleConnectedComponentsDCAllComponents test. Signed-off-by: Bertrand Rix <[email protected]>

Directly return ComponentResult instead of using a temporary variable.

0772182

Signed-off-by: Bertrand Rix <[email protected]>

annetill reviewed Apr 30, 2021

View reviewed changes

Add filter on main synchronous component on top of the connected comp…

bb9e415

…onent filter. Signed-off-by: Bertrand Rix <[email protected]>

obrix force-pushed the handle_several_cc_networks branch from 6d8be2e to bb9e415 Compare April 30, 2021 14:23

Add a test for security analysis where several cc are present on the …

58e532a

…network. Just test the computation is ok, only the main cc is computed. Signed-off-by: Bertrand Rix <[email protected]>

annetill reviewed Apr 30, 2021

View reviewed changes

Adapt code to matching branch on core.

f18d7d6

Signed-off-by: Bertrand Rix <[email protected]>

geofjamg requested changes May 17, 2021

View reviewed changes

flo-dup added 4 commits May 18, 2021 11:19

Bump core 4.2.0-RC1

d3b95b8

Signed-off-by: Florian Dupuy <[email protected]>

First network is always the (main, main) one

5e15115

Signed-off-by: Florian Dupuy <[email protected]>

Avoid filtering with a true predicate

b71cc14

Signed-off-by: Florian Dupuy <[email protected]>

Adapt unit test to 4.2.0-SNAPSHOT changes

91d1665

Signed-off-by: Florian Dupuy <[email protected]>

Merge branch 'master' into handle_several_cc_networks

c6d8435

flo-dup force-pushed the handle_several_cc_networks branch from 9a2a03e to c6d8435 Compare May 18, 2021 09:21

geofjamg requested changes May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java Outdated Show resolved Hide resolved

annetill and others added 6 commits May 18, 2021 16:16

Use LoadFlowParameters connectedComponentMode.

bc7b5cb

Signed-off-by: Anne Tilloy <[email protected]>

Fix DC value voltage initializer.

9a74b0e

Signed-off-by: Anne Tilloy <[email protected]>

First LfNetwork is always the (main,main) one (part 2)

45a3af2

Signed-off-by: Florian Dupuy <[email protected]>

runMultiple -> run

ac3456c

Signed-off-by: Florian Dupuy <[email protected]>

Reporter logs update

3e73f1c

Signed-off-by: Florian Dupuy <[email protected]>

Update logs to identify synchronous component of network studied

21701b3

Signed-off-by: Florian Dupuy <[email protected]>

annetill reviewed May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/ac/outerloop/AcloadFlowEngine.java Show resolved Hide resolved

annetill reviewed May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java Outdated Show resolved Hide resolved

annetill reviewed May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java Outdated Show resolved Hide resolved

annetill reviewed May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java Outdated Show resolved Hide resolved

flo-dup added 2 commits May 18, 2021 21:14

Corrections following review

cea10d5

Signed-off-by: Florian Dupuy <[email protected]>

get replaced by is (boolean)

21f5cc0

Signed-off-by: Florian Dupuy <[email protected]>

geofjamg requested changes May 18, 2021

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/impl/LfNetworkLoaderImpl.java Outdated Show resolved Hide resolved

Corrections following reviews

a37bb62

Signed-off-by: Florian Dupuy <[email protected]>

annetill approved these changes May 20, 2021

View reviewed changes

annetill and others added 2 commits May 20, 2021 08:40

Merge branch 'master' into handle_several_cc_networks

ff5b0b7

Trying to fix the NameSlackBusSelector

5742622

Signed-off-by: Florian Dupuy <[email protected]>

obrix mentioned this pull request May 20, 2021

Use new parameters isDcUseTransformerRatio and countriesToBalance #308

Merged

5 tasks

flo-dup and others added 2 commits May 20, 2021 13:24

NameSlackBusSelector only for (0,0) component

362c986

Signed-off-by: Florian Dupuy <[email protected]>

Fix tests.

90aef6d

Signed-off-by: Anne Tilloy <[email protected]>

annetill approved these changes May 20, 2021

View reviewed changes

annetill merged commit c5a3efd into master May 20, 2021

annetill deleted the handle_several_cc_networks branch May 20, 2021 12:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle all connected components of a network #295

Handle all connected components of a network #295

obrix commented Apr 29, 2021

geofjamg left a comment

obrix commented Apr 29, 2021

annetill commented Apr 29, 2021

annetill left a comment

annetill Apr 29, 2021

obrix Apr 29, 2021

annetill Apr 29, 2021

annetill Apr 30, 2021

annetill Apr 30, 2021

obrix Apr 30, 2021 •

edited

Loading

annetill Apr 30, 2021

geofjamg May 17, 2021

sonarqubecloud bot commented May 20, 2021

annetill left a comment

Handle all connected components of a network #295

Handle all connected components of a network #295

Conversation

obrix commented Apr 29, 2021

geofjamg left a comment

Choose a reason for hiding this comment

obrix commented Apr 29, 2021

annetill commented Apr 29, 2021

annetill left a comment

Choose a reason for hiding this comment

annetill Apr 29, 2021

Choose a reason for hiding this comment

obrix Apr 29, 2021

Choose a reason for hiding this comment

annetill Apr 29, 2021

Choose a reason for hiding this comment

annetill Apr 30, 2021

Choose a reason for hiding this comment

annetill Apr 30, 2021

Choose a reason for hiding this comment

obrix Apr 30, 2021 • edited Loading

Choose a reason for hiding this comment

annetill Apr 30, 2021

Choose a reason for hiding this comment

geofjamg May 17, 2021

Choose a reason for hiding this comment

sonarqubecloud bot commented May 20, 2021

annetill left a comment

Choose a reason for hiding this comment

obrix Apr 30, 2021 •

edited

Loading