Refactor parameters #438
Refactor parameters #438
Conversation
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
@annetill It was not my intend for this PR, but I think I fixed an ugly bug. In the security analysis, when phase shifter control is activated in |
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
| @@ -327,4 +351,178 @@ public static OpenLoadFlowParameters get(LoadFlowParameters parameters) { | |||
| } | |||
| return parametersExt; | |||
| } | |||
|
|
|||
| public static void logDc(LoadFlowParameters parameters, OpenLoadFlowParameters parametersExt) { | |||
| LOGGER.info("Slack bus selection mode: {}", parametersExt.getSlackBusSelectionMode()); | |||
There was a problem hiding this comment.
Maybe you have to add here LOGGER.info("Direct current: {}", parameters.isDc());, no ?
| return acParameters; | ||
| } | ||
|
|
||
| public static AcLoadFlowParameters createAcParameters(LoadFlowParameters parameters, OpenLoadFlowParameters parametersExt, |
There was a problem hiding this comment.
Why is this class public? Finally only the two previous ones are used in the rest of the code.
There was a problem hiding this comment.
It is used in another private project
| return dcParameters; | ||
| } | ||
|
|
||
| public static DcLoadFlowParameters createDcParameters(LoadFlowParameters parameters, OpenLoadFlowParameters parametersExt, |
There was a problem hiding this comment.
It might be used in another private project
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: Geoffroy Jamgotchian [email protected]
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A refactoring bu also a bug fix...
What is the current behavior? (You can also link to an open issue here)
All code for converting powsybl api
LoadflowParametersto internal parameters (AcLoadFlowParametersandDcLoadFlowParameters) is inOpenLoadProviderwhich is not the right place.What is the new behavior (if this is a feature change)?
Everything has been moved to
OpenLoadFlowParametersDoes this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)