Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch contingency support #501

Merged
merged 9 commits into from
Apr 19, 2022
Merged

Switch contingency support #501

merged 9 commits into from
Apr 19, 2022

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Apr 8, 2022

Signed-off-by: Geoffroy Jamgotchian [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

geofjamg and others added 2 commits April 8, 2022 22:15
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg requested a review from annetill April 12, 2022 15:44
Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the impact on sensitivity analysis? As we are in bus view for sensitivity analysis (right?), we will fall in the exception?

@geofjamg
Copy link
Member Author

What about the impact on sensitivity analysis? As we are in bus view for sensitivity analysis (right?), we will fall in the exception?

I have to test it. For DC sensitivity analysis it is same issue as for contingency propagation: so it is an ongoing topic.
For AC sensitivity analysis it should work without any problem as we rebuild the jacobian matrix for each contingency => to test

@geofjamg geofjamg requested a review from annetill April 18, 2022 20:12
@geofjamg
Copy link
Member Author

What about the impact on sensitivity analysis? As we are in bus view for sensitivity analysis (right?), we will fall in the exception?

I have to test it. For DC sensitivity analysis it is same issue as for contingency propagation: so it is an ongoing topic. For AC sensitivity analysis it should work without any problem as we rebuild the jacobian matrix for each contingency => to test

I just threw an exception in case of sensitivity analysis. As calculation is done on bus/view (breakers = false in DC and in AC), there is a LOT a work to make it working for sensitivity analysis and not sure somebody needs it. So let's see that later.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
0.0% 0.0% Duplication

Copy link
Member

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, later for sensitivity analysis !

@geofjamg geofjamg merged commit 65997de into main Apr 19, 2022
@geofjamg geofjamg deleted the switch_contingency branch April 19, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants