Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC equations refactoring #543

Merged
merged 13 commits into from
Jun 8, 2022
Merged

AC equations refactoring #543

merged 13 commits into from
Jun 8, 2022

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jun 1, 2022

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring

What is the new behavior (if this is a feature change)?
All AC esquations have bee rewritten to be available as a static function.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@geofjamg geofjamg force-pushed the ac_equations_refactoring branch from 8a04030 to 46b9530 Compare June 1, 2022 19:03
@geofjamg geofjamg changed the title AC equations refactoring [WIP] AC equations refactoring Jun 1, 2022
@geofjamg geofjamg force-pushed the ac_equations_refactoring branch 2 times, most recently from 9c7371d to 35a79df Compare June 5, 2022 20:03
geofjamg added 7 commits June 6, 2022 11:59
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@geofjamg geofjamg force-pushed the ac_equations_refactoring branch from 35a79df to 0232c8f Compare June 6, 2022 10:00
@geofjamg geofjamg changed the title [WIP] AC equations refactoring AC equations refactoring Jun 6, 2022
geofjamg and others added 6 commits June 6, 2022 22:15
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

99.7% 99.7% Coverage
0.0% 0.0% Duplication

@geofjamg geofjamg merged commit 1c178fa into main Jun 8, 2022
@geofjamg geofjamg deleted the ac_equations_refactoring branch June 8, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant