Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current limit violations detection in DC security analysis #549

Merged
merged 18 commits into from
Jun 14, 2022

Conversation

Hadrien-Godard
Copy link
Member

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces the handling of current limit violations in the DC security analysis.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@Hadrien-Godard Hadrien-Godard requested a review from annetill June 7, 2022 09:34
@Hadrien-Godard Hadrien-Godard force-pushed the current-limit-in-dc-sa branch from 6707e39 to 00248c2 Compare June 7, 2022 09:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@annetill annetill changed the title [WIP] Current limit in dc sa Current limit violations detection in DC security analysis Jun 7, 2022
Signed-off-by: Anne Tilloy <[email protected]>
@@ -91,6 +93,8 @@ public class OpenLoadFlowParameters extends AbstractExtension<LoadFlowParameters

public static final String TRANSFORMER_VOLTAGE_CONTROL_MODE_NAME = "transformerVoltageControlMode";

public static final String DC_COS_PHI_NAME = "dcCosPhi";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annetill are you sure cos(phi) is the right naming? phi is used in OLF as the voltage angle. Would power factor more usual way of naming this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right, my mistake, I am going to fix the name.

annetill and others added 4 commits June 13, 2022 18:04
@annetill annetill merged commit 881b629 into main Jun 14, 2022
@annetill annetill deleted the current-limit-in-dc-sa branch June 14, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants