Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC security analysis: make contingency propagation optional #571

Merged
merged 10 commits into from
Jul 5, 2022

Conversation

annetill
Copy link
Member

Signed-off-by: Anne Tilloy [email protected]

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

No.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

The contingency propagation for AC security analyses is optional, set to true by default.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@@ -605,11 +605,12 @@ void testContingencyPropagationLfSwitch() {

SensitivityAnalysisResult result = sensiRunner.run(network, factors, contingencies, Collections.emptyList(), sensiParameters);

// FIXME: contingency propagation is deactivated for the moment.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geofjamg I have temporary deactivated the contingency propagation for sensitivity analysis. I am going to switch the sensitivity analysis on the bus/breaker view in an other PR. But, if it is too dangerous for you, I can introduce a parameter on the sensitivity analysis in this PR and the propagation will be done on the bus/view, with all the problems that you know.

@annetill annetill requested review from geofjamg and flo-dup June 29, 2022 11:12
annetill and others added 5 commits June 29, 2022 13:27
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

Copy link
Member Author

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @flo-dup for your help on this PR. It is really cleaner!

@annetill annetill merged commit 7175f18 into main Jul 5, 2022
@annetill annetill deleted the propagated-contingency-refactoring branch July 5, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants