AC Security Analysis with operator strategies #590

annetill · 2022-08-17T13:57:53Z

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the new behavior (if this is a feature change)?
We are able to simulate operator strategies, like switch closing and opening, phase shifter tap change, line reconnection.

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

src/main/java/com/powsybl/openloadflow/network/LfAction.java

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

src/main/java/com/powsybl/openloadflow/network/LfAction.java

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

geofjamg · 2022-08-18T21:34:03Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

        try {
            network.getSwitchStream().filter(sw -> sw.getVoltageLevel().getTopologyKind() == TopologyKind.NODE_BREAKER)
                    .forEach(sw -> sw.setRetained(false));
            allSwitchesToOpen.forEach(sw -> sw.setRetained(true));
+            allSwitchesToClose.forEach(sw -> {
+                sw.setRetained(true);
+                sw.setOpen(false); // in order to be present in the network.


This is the ugly part of this PR. Not easy to do otherwise.

:-) thanks! Note that there is for me a bug in the current code because we create a variant but we don't use it.

geofjamg · 2022-08-18T21:35:18Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

+            engine.getContext().getEquationSystem();
+            if (!allSwitchesToClose.isEmpty()) {
+                var connectivity = network.getConnectivity();
+                allSwitchesToClose.stream().map(Identifiable::getId).forEach(id -> {


I'am going to think about a way to avoid this hack (probably no way...)

geofjamg · 2022-08-18T21:36:36Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

+                                            operatorStrategyResults.add(optionalOperatorStrategyResult.get());
+                                        }
+                                    } else {
+                                        LOGGER.warn("A contingency has several operator strategies: not supported yet");


Do you plan to implement it in this PR?

No, because it requires a save/restore of the network state just after contingency.

And why is it a problem? Is there something different to do that what we are doing for contingencies?

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

geofjamg · 2022-08-18T21:38:36Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

+
+            boolean postActionsComputationOk = postActionsLoadFlowResult.getNewtonRaphsonStatus() == NewtonRaphsonStatus.CONVERGED;
+            // FIXME: to be checked.
+            var postActionsViolationManager = new LimitViolationManager(preContingencyLimitViolationManager, violationsParameters);


So here reference is still the base case, for violation increase criteria?

@sylvlecl and @EtienneLt : it was my question... I don't know :-) Any opinion ?

Internal processes compare post-action state to pre-contingency state to detect worsened violations.

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

geofjamg · 2022-08-18T21:41:54Z

src/main/java/com/powsybl/openloadflow/network/LfAction.java

+        }
+        if (enabledBranch != null) {
+            enabledBranch.setDisabled(false);
+            enabledBranch.getBus1().setDisabled(false);


Do we need to enable buses ? In which case?

Yes we need it (see the unit tests) and indeed in it really not enough. For example, when we reconnect a switch that will reconnect a small component, the buses and branches of this component but be enabled. This is not handle here. @flo-dup how to do this with your connectivity?

So yes, this is not the right thing to do. We should be able to get from connectivity, the list of buses and branches that have been reconnected to main connected component. Here by just enabling side buses, we only enable a small part of potential sub network reconnected.

geofjamg · 2022-08-18T21:43:44Z

src/main/java/com/powsybl/openloadflow/network/LfAction.java

+
+    private LfNetwork network;
+
+    public LfAction(Action action, LfNetwork network) {


So the plan here is to support a list of action and that LfAction will be the sum/result of PowSyBl Core actions for the current strategy?

No: we keep a list of LfAction for an operator strategy. I am not able to do better...

When all design issues will be solved it should be easy to support

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Florian Dupuy <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg · 2022-10-14T15:27:19Z

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java

+                var connectivity = network.getConnectivity();
+                allSwitchesToClose.stream().map(Identifiable::getId).forEach(id -> {
+                    LfBranch branch = network.getBranchById(id);
+                    branch.setDisabled(true);


@annetill we only re-enable switches to close, but we should do it to for sub network that could be move out of main cc by this branch disabling?

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Signed-off-by: Anne Tilloy <[email protected]>

…wsybl-open-loadflow into try-as-with-actions-2

annetill · 2022-10-17T07:46:12Z

src/main/java/com/powsybl/openloadflow/network/LfAction.java

+
+        // re-update connectivity according to post contingency state (revert after LfContingency apply)
+        connectivity.startTemporaryChanges();
+        contingency.getDisabledBranches().forEach(connectivity::removeEdge);


Do we support a bus contingency (bus/bar section or bus from a bus/breaker topology)? If one day yes, we also have to remove the disabled buses.

yes, we should add it now to not forget it later

annetill · 2022-10-17T07:47:10Z

src/main/java/com/powsybl/openloadflow/network/LfNetwork.java

@@ -546,6 +546,7 @@ public GraphConnectivity<LfBus, LfBranch> getConnectivity() {
            getBranches().stream()
                    .filter(b -> b.getBus1() != null && b.getBus2() != null)
                    .forEach(b -> connectivity.addEdge(b.getBus1(), b.getBus2(), b));
+            connectivity.setMainComponentVertex(getSlackBus());


@flo-dup can you please just take a look at this change and tell us if it is okay for you. Thanks!

Signed-off-by: Anne Tilloy <[email protected]>

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

sonarqubecloud · 2022-10-18T13:52:52Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

91.9% Coverage
0.0% Duplication

annetill

@geofjamg I agree with your improvements. Thanks for your help!

annetill changed the base branch from main to connectivity_v2 August 17, 2022 13:58

annetill commented Aug 17, 2022

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/LfAction.java Outdated Show resolved Hide resolved

annetill commented Aug 17, 2022

View reviewed changes

src/main/java/com/powsybl/openloadflow/sa/AcSecurityAnalysis.java Outdated Show resolved Hide resolved

annetill commented Aug 17, 2022

View reviewed changes

src/main/java/com/powsybl/openloadflow/network/LfAction.java Outdated Show resolved Hide resolved

annetill requested a review from geofjamg August 17, 2022 15:08

Base automatically changed from connectivity_v2 to main August 17, 2022 21:03

geofjamg force-pushed the try-as-with-actions-2 branch from 430450c to 2e77e2c Compare August 17, 2022 21:47

annetill added the PR: next-release label Aug 18, 2022

geofjamg reviewed Aug 18, 2022

View reviewed changes

geofjamg and others added 21 commits August 24, 2022 23:54

Support multiple add and remove of the same edge in connectivity

ea07d2d

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Fix unit test

3dcf4b6

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Fix comment

bb753a2

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

new API

eb55d67

Signed-off-by: Florian Dupuy <[email protected]>

Adapt MinimumSpanningTreeConnectivity to new API

9c61ead

Signed-off-by: Florian Dupuy <[email protected]>

Fix implementation and connectivity calls

9f10f61

Signed-off-by: Florian Dupuy <[email protected]>

Always check before calling reset that some modifications were made

79949cf

Signed-off-by: Florian Dupuy <[email protected]>

Fix reset

14a066f

Signed-off-by: Florian Dupuy <[email protected]>

Replace save/reset mechanism by startTmpChanges/undoTmpChanges mechanism

38ddfa7

Signed-off-by: Florian Dupuy <[email protected]>

Save work.

c4e727d

Signed-off-by: Anne Tilloy <[email protected]>

Fix some code smells.

5c7c2cf

Signed-off-by: Anne Tilloy <[email protected]>

Support a list of actions for an operator strategy.

f94e2e1

Signed-off-by: Anne Tilloy <[email protected]>

Fix bug.

469648a

Signed-off-by: Anne Tilloy <[email protected]>

Add unit test.

973ab64

Signed-off-by: Anne Tilloy <[email protected]>

Add unit test.

12c68da

Signed-off-by: Anne Tilloy <[email protected]>

Add unit test.

8cacc54

Signed-off-by: Anne Tilloy <[email protected]>

Fix merge

d308bd3

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Increase coverage.

33da158

Signed-off-by: Anne Tilloy <[email protected]>

Fix code smells.

bddb21a

Signed-off-by: Anne Tilloy <[email protected]>

Cleanup

1b36f58

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Cleanup

fb97b1d

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

annetill and others added 7 commits October 13, 2022 13:10

Clean.

7b941a1

Signed-off-by: Anne Tilloy <[email protected]>

Save.

7db0284

Signed-off-by: Anne Tilloy <[email protected]>

Fix code smells.

f1bc076

Signed-off-by: Anne Tilloy <[email protected]>

Clean.

e104e73

Signed-off-by: Anne Tilloy <[email protected]>

Fix code smell.

a4f72f4

Signed-off-by: Anne Tilloy <[email protected]>

Merge branch 'main' into try-as-with-actions-2

0d17aff

# Conflicts: # src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java

Refactoring

a5106c4

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg reviewed Oct 14, 2022

View reviewed changes

geofjamg added 4 commits October 14, 2022 21:44

Refactoring

e2885fa

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Fix initial topo restoration

d1f79db

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Clean

1d5aafe

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Clean

496635b

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg changed the title ~~[WIP] Try Security Analysis with operator strategies~~ Security Analysis with operator strategies Oct 14, 2022

Clean

3b281fa

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

geofjamg approved these changes Oct 14, 2022

View reviewed changes

annetill added 2 commits October 17, 2022 08:56

Improve unit test.

d0d15d5

Signed-off-by: Anne Tilloy <[email protected]>

Merge branch 'try-as-with-actions-2' of https://github.com/powsybl/po…

f73596a

…wsybl-open-loadflow into try-as-with-actions-2

annetill changed the title ~~Security Analysis with operator strategies~~ AC Security Analysis with operator strategies Oct 17, 2022

annetill commented Oct 17, 2022

View reviewed changes

annetill and others added 6 commits October 17, 2022 09:52

Fix indentation.

322ff56

Signed-off-by: Anne Tilloy <[email protected]>

Clean.

f687551

Signed-off-by: Anne Tilloy <[email protected]>

Merge.

4ce609d

Signed-off-by: Anne Tilloy <[email protected]>

Try to fix open lines.

fb670ca

Signed-off-by: Anne Tilloy <[email protected]>

Force naive algo in case of operator stategies

0247979

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

Fix PreviousValueVoltageInitializer

6acd8ff

Signed-off-by: Geoffroy Jamgotchian <[email protected]>

annetill commented Oct 18, 2022

View reviewed changes

annetill merged commit 2e8528d into main Oct 18, 2022

annetill deleted the try-as-with-actions-2 branch October 18, 2022 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AC Security Analysis with operator strategies #590

AC Security Analysis with operator strategies #590

annetill commented Aug 17, 2022 •

edited by geofjamg

Loading

geofjamg Aug 18, 2022

annetill Aug 19, 2022

geofjamg Aug 18, 2022

geofjamg Aug 18, 2022

annetill Aug 19, 2022

geofjamg Aug 26, 2022

geofjamg Aug 18, 2022

annetill Aug 19, 2022

annetill Aug 19, 2022

geofjamg Aug 18, 2022

annetill Aug 19, 2022

geofjamg Aug 26, 2022

geofjamg Aug 18, 2022

annetill Aug 19, 2022

geofjamg Aug 26, 2022

geofjamg Oct 14, 2022

annetill Oct 17, 2022

geofjamg Oct 17, 2022

annetill Oct 17, 2022

sonarqubecloud bot commented Oct 18, 2022

annetill left a comment


		private LfNetwork network;

		public LfAction(Action action, LfNetwork network) {

AC Security Analysis with operator strategies #590

AC Security Analysis with operator strategies #590

Conversation

annetill commented Aug 17, 2022 • edited by geofjamg Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 18, 2022

annetill left a comment

Choose a reason for hiding this comment

annetill commented Aug 17, 2022 •

edited by geofjamg

Loading