Connectivity: compute edges/vertices moves from/to main component #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-dup
changed the title
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
flo-dup
force-pushed
the
compute_connected_deltas
branch
from
2ace94a to
667e1cc
Compare
Signed-off-by: Florian Dupuy <[email protected]>
Signed-off-by: Florian Dupuy <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem ?
Yes, fixes #594
What kind of change does this PR introduce?
Feature
What is the new behavior (if this is a feature change)?
Compute edges/vertices moves from/to main component thanks to following methods:
GraphConnectivity::getEdgesAddedToMainComponentGraphConnectivity::getVerticesAddedToMainComponentGraphConnectivity::getVerticesRemovedFromMainComponentGraphConnectivity::getEdgesRemovedFromMainComponentOther information:
Computing the edges/vertices moves is done by comparing
These comparisons should not be very costly as the small connected components should remain small in most use cases.
Note that some special care was needed because of edges removed then added (or the opposite) during the same temporary changes.