Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] Set own user agent for dhooks-lite #248

Merged
merged 1 commit into from
Dec 15, 2024
Merged

[CHANGE] Set own user agent for dhooks-lite #248

merged 1 commit into from
Dec 15, 2024

Conversation

ppfeufer
Copy link
Owner

Description

Changed

  • Set own user agent for dhooks-lite

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.13%. Comparing base (ee49610) to head (19e148f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
fleetpings/helper/discord_webhook.py 85.72% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   76.90%   77.13%   +0.23%     
==========================================
  Files          15       15              
  Lines         606      612       +6     
  Branches       48       48              
==========================================
+ Hits          466      472       +6     
  Misses        128      128              
  Partials       12       12              
Files with missing lines Coverage Δ
fleetpings/constants.py 100.00% <100.00%> (ø)
fleetpings/helper/discord_webhook.py 55.56% <85.72%> (+12.70%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee49610...19e148f. Read the comment docs.

@ppfeufer ppfeufer merged commit 1851e18 into master Dec 15, 2024
56 checks passed
@ppfeufer ppfeufer deleted the user-agent branch December 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant