Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next Version - 2.14.1 #80

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Next Version - 2.14.1 #80

merged 4 commits into from
Aug 4, 2022

Conversation

ppfeufer
Copy link
Owner

@ppfeufer ppfeufer commented Aug 4, 2022

Description

Fixed

  • Don't show :: in front of the ping text headline when no ping target is selected

Changed

  • Simplified checks for mandatory fields in JS (If you are still using Internet
    Explorer 11 or older, you should feel bad and update to a modern browser)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not
    work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #80 (bedaa50) into master (ae29979) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   71.79%   71.66%   -0.13%     
==========================================
  Files          16       16              
  Lines         592      593       +1     
  Branches       84       85       +1     
==========================================
  Hits          425      425              
- Misses        146      147       +1     
  Partials       21       21              
Impacted Files Coverage Δ
fleetpings/helper/ping_context.py 17.50% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae29979...bedaa50. Read the comment docs.

@ppfeufer ppfeufer merged commit 98cdd9a into master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant