Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix song select matching label not using right terminology #23000

Merged
merged 6 commits into from
Apr 18, 2023

Conversation

Joehuu
Copy link
Member

@Joehuu Joehuu commented Mar 27, 2023

The beatmap terminology has been confusing as we've been mixing up the terms internally, see this table:

Internal (in code) Wiki term (user shown)
Beatmap Difficulty
Beatmap set Beatmap

Before:
osu!_QMEZshT8M0

After:
osu!_BZEIotadPV

Not sure if it should be the other way around (i.e. 1,117 matching difficulties (217 beatmaps)). I prefer the smaller number first though.

@peppy
Copy link
Member

peppy commented Mar 28, 2023

I considered this when making the change but don't want two numbers. And just saying "x difficulties matching" looks weird/wrong.

@Joehuu
Copy link
Member Author

Joehuu commented Apr 3, 2023

The only solution is to be more verbose with "x matching beatmap difficulties".

@Joehuu Joehuu changed the title Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity Fix song select matching label not stating difficulties Apr 11, 2023
@peppy
Copy link
Member

peppy commented Apr 16, 2023

Still prefer what I had 🤷

@Joehuu
Copy link
Member Author

Joehuu commented Apr 16, 2023

Not sure how to proceed in fixing the main issue I was trying to fix (two different numbers, same labels):
osu!_TrGdEyWOaD
osu!_ZQ0kCZ5F4y

@peppy
Copy link
Member

peppy commented Apr 16, 2023

Making the first one count difficulties (not sets) is probably best.

@Joehuu
Copy link
Member Author

Joehuu commented Apr 17, 2023

Making the first one count difficulties (not sets) is probably best.

My question then is should the labels change to "beatmap difficulties"? If not, the wiki is wrong with the terminology and should be changed.

@peppy
Copy link
Member

peppy commented Apr 17, 2023

Another option would be to just use "matches" and remove the "beatmap" part completely. Shall we go with that to avoid any confusion?

@Joehuu
Copy link
Member Author

Joehuu commented Apr 18, 2023

Making the label ambiguous works, have applied.

@Joehuu Joehuu changed the title Fix song select matching label not stating difficulties Fix song select matching label not using right terminology Apr 18, 2023
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@peppy peppy merged commit 26a2d1f into ppy:master Apr 18, 2023
@Joehuu Joehuu deleted the fix-beatmap-terminology branch April 18, 2023 04:53
@Joehuu Joehuu added this to the Next release? milestone Apr 18, 2023
@Joehuu Joehuu assigned Joehuu and unassigned Joehuu Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants