-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix song select matching label not using right terminology #23000
Conversation
…difficulty count for less ambiguity
I considered this when making the change but don't want two numbers. And just saying "x difficulties matching" looks weird/wrong. |
The only solution is to be more verbose with "x matching beatmap difficulties". |
Still prefer what I had 🤷 |
Making the first one count difficulties (not sets) is probably best. |
My question then is should the labels change to "beatmap difficulties"? If not, the wiki is wrong with the terminology and should be changed. |
Another option would be to just use "matches" and remove the "beatmap" part completely. Shall we go with that to avoid any confusion? |
Making the label ambiguous works, have applied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
The beatmap terminology has been confusing as we've been mixing up the terms internally, see this table:
Before:

After:

Not sure if it should be the other way around (i.e.1,117 matching difficulties (217 beatmaps)
). I prefer the smaller number first though.