-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade packages #27920
Upgrade packages #27920
Conversation
Do we know whether the underlying issue causing #27577 has been fixed by now? The realm-core issue is still open. |
Unsure if the above is related, but on my Pixel 6a (Android 14), the game gets stuck on the splash screen, which seems to be the same issue as #27738 (the last Realm bump The game doesn't crash and logcat doesn't seem to output anything helpful. Also tried on Android 11 and 8 devices + discussion above had an Xperia 5 II (Android 10-12) and they don't have this problem, so it's maybe an Android 14 thing. |
@Joehuu are you able to pull logs from that? |
Here's the log when I opened the app and waiting a minute: |
Very concerning. Not much of anything useful in the logs as you say. |
Pushed merge conflict resolution & code quality fixes here.
Cannot reproduce, game launches fine here. And I should be on android 14. Haven't tested at all besides that. |
Tested and still getting the same error in example 2 of realm/realm-core#7454 using an exFAT external drive on Windows. Seemingly doesn't happen on macOS using the same drive. |
Thanks for testing, left a note in the realm issue thread. |
Tested again on https://github.com/realm/realm-dotnet/releases/tag/12.1.0 and my two issues (Pixel 6a Android 14 and external exFAT on Windows) still happen. |
Yeah, unfortunately there's been no push to fix the issue yet 😢 . |
The external exFAT on Windows issue seems to be fixed in https://github.com/realm/realm-dotnet/releases/tag/12.3.0, but Android 14 on my Pixel 6a still has the same issue. |
@Joehuu has the android issue been reported to realm's end yet? are you 100% sure it's realm related? |
Not that I know of, no. I'm sure it's realm as just changing realm versions triggers the Android 14 on Pixel issue. It started since https://github.com/realm/realm-dotnet/releases/tag/11.6.1. Just to see if the external exFAT on Windows issue is related, it is not. That started in https://github.com/realm/realm-dotnet/releases/tag/11.7.0 but as I said, it's fixed in the latest release. |
We...probably should report it to Realm then? |
Found the issue, maybe: realm/realm-core#7950 |
Heads up that I might have a possible route forward; see realm/realm-core#7950 (comment). If realm ends up being fully dead (core and sdks) and we end up forking, maybe adopting that cmake patch is going to make things sorta-kinda work for us at least...? @Joehuu would you be able to test this on device to confirm? You can grab nuget packages with the fix from the artifact listing at https://github.com/bdach/realm-dotnet/actions/runs/11255982167. |
Works fine. Did some recommended beatmap downloading and playing/completing a beatmap with no problems. |
This also downgrades nunit to be aligned across all projects. Getting it up-to-date is a bit high effort.
c41530e
to
d5f2bdf
Compare
Realm have fixed the android issue so I've brought this up-to-date for consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything still seems to be fine after retesting.
I've done some basic testing for multiplayer, score submission, and beatmap imports. Looks to work. Not willing to spend more time testing this, so let's just go with it and hope nothing breaks. |
Mainly for new realm version, but some others along the way.
Not 100% on the SignalR change with exceptions (have not tested yet). I'll test later today if no one beats me.