Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scaling down to 5% in popover scale dialog #30482

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Nov 3, 2024

Request from mapper IRL.

@OliBomby
Copy link
Contributor

OliBomby commented Nov 3, 2024

How about letting it go down to 0% or even negative? Such scaling values would also produce valid results. I think 0% could be useful while scaling on a single axis to squash the axis, or turn a pattern into a stack.

@peppy
Copy link
Member Author

peppy commented Nov 4, 2024

The issue with letting it go lower would be that the slider bar gets silly.

It would need to be textbox entry only. You're welcome to propose a diff for that, I wasn't willing to put in the effort without a user request because it's more complicated.

@bdach
Copy link
Collaborator

bdach commented Nov 4, 2024

This didn't actually work properly. I have made it work with f616c7b.

@bdach bdach merged commit 7d39765 into ppy:master Nov 4, 2024
11 of 13 checks passed
@OliBomby
Copy link
Contributor

OliBomby commented Nov 4, 2024

The issue with letting it go lower would be that the slider bar gets silly.

You mean it would get silly for negative values right? For 0% minimum scaling it shouldn't make much of a difference to the slider bar since that only makes the range 0.5% bigger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants