JSON RPC support #46
Merged
JSON RPC support #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i'm sorry to all the open PRs about this, i'll port them myself. the structure of the code was too confusing for too long, it was a relic of having two binaries and trying to share as little as possible between them to reduce code bloat. but now that we have a single binary it doesn't make sense anymore and is very confusing. this change will hopefully make the code more clear for anyone not already familiar with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a prerequisite for implementing #22 and possibly #26 in a way i'd be happy merging. the advantage is that we'll be able to do more manipulation of LSP when we understand it better, the disadvantage is possibly breaking some language servers with slightly broken LSP implementation and will have to implement more workarounds for those.