Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize lsp#omni#get_vim_completion_items() #835

Merged
merged 4 commits into from
Jun 13, 2020
Merged

optimize lsp#omni#get_vim_completion_items() #835

merged 4 commits into from
Jun 13, 2020

Conversation

prabirshrestha
Copy link
Owner

@prabirshrestha prabirshrestha commented Jun 7, 2020 •
edited
Loading

This now improves autocompletion when having large complete items i.e. >2,000 items.
The fix is by primarily caching.

  • Cache as much as possible
  • Remove deprecated methods
  • Update asyncomplete-lsp to use the new methods
  • update omnifunc to use the new methods
  • fix tests

notify other plugin others for the breaking changes

This does contain breaking changes will late it bake before merging.

This was referenced Jun 9, 2020
Closed
Merged
This was referenced Jun 9, 2020
Merged
Closed
Closed
@prabirshrestha prabirshrestha merged commit e0cacff into master Jun 13, 2020
@prabirshrestha prabirshrestha deleted the perf-get-omnni-completion-items branch June 13, 2020 09:11
LumaKernel pushed a commit to LumaKernel/vim-lsp that referenced this pull request Aug 4, 2020
@prabirshrestha @LumaKernel
optimize lsp#omni#get_vim_completion_items() (prabirshrestha#835)
31dadca 
* optimize

* fix two omni tests

* fix omni tests
@prabirshrestha prabirshrestha mentioned this pull request Jan 11, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@prabirshrestha