Add source_provider setting for edit link (#35 proposal) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allow to use `source_provider` to handle the case where `source_directory` is not a well-known url (https://gitlab.com, https://github.com, https://bitbucket.org). This patch implies that project using spinx_basic_ng update their `theme.conf` file to add a `source_directory =` default setting (else this patch trigger errors at runtime).
|
Would this be better served by #34? |
|
My bad, #34 is just fine; I just do not see it before posting :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allow to use
source_providerto handle the case wheresource_directoryis not a well-known url (https://gitlab.com, https://github.com, https://bitbucket.org).This patch implies that project using spinx_basic_ng update their
theme.conffile to add asource_directory =default setting (else this patch trigger errors at runtime). Not sure if it is possible and/or desired to handle the case wheretheme.confis not updated.