server, webui: add pool descriptions #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix praiskup#133 An example description for a builder: aws_x86_64_normalreserved_prod: description: > A pool of reserved x86_64 instances in the Amazon AWS Fedora organization. Thank you IBM for sponsoring these builders.
praiskup
reviewed
Jan 6, 2025
resallocwebui/app.py
Outdated
| @@ -37,12 +38,20 @@ def pools(): | |||
| # e.g. result["copr_hv_x86_64_01_prod"]["STARTING"] | |||
| result = {} | |||
|
|
|||
| _, pools_from_config = reload_config() | |||
There was a problem hiding this comment.
please test that this doesn't break selinux (apache is unable to read resalloc's configuration files)
There was a problem hiding this comment.
It had some issues with /var/log/resallocserver/main.log which I fixed with the follow-up commit but surprisingly SELinux has no issues with this (on copr-be-dev)
There was a problem hiding this comment.
Yeah, I probably mixed up :-) SELinux is likely blocking apache to write into main.log.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
It does some logging which causes permission errors, it is misleading because it logs as the manager, etc.
FrostyX
force-pushed
the
pool-description
branch
from
ca08bc4 to
a6c3c73
Compare
praiskup
approved these changes
Jan 7, 2025
|
For the record, I am adding the production descriptions here - https://pagure.io/fedora-infra/ansible/pull-request/2423 |
ryanlerch
pushed a commit
to fedora-infra/ansible
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #133
An example description for a builder: