Hotfix handle 429 timeout #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using config variables as globals makes it so we don't need to drill all of them as function arguments, instead we just use them where we need to. This should make it easier to modify in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a
--retry-on-429option for distributors when usingtransfersub-command.This was previously the default behaviour, but we learned that if
spl-token transferreturns a HTTP Too Many Requests error (429), this is not a guarantee of a failed transaction. This is a bug in howspl-tokenhandles those errors and according to Solana developer support, a fix is on the way.A transaction happening despite this error is rare, but it can happen. The safe way to treat this error is to consider the transaction as unconfirmed, until the error is fixed in
spl-token. The--retry-on-429option will use the old behaviour, where the tool retried the transaction if it encountered this error.