You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is causing a bug for me where my route transition is messed up/reversed every other time it runs. I removed the reverse animation logic in componentWillLeave and it fixes the issue. Curious if anyone else is seeing this as it seems to be a pretty big bug. I'll go ahead and submit a PR.
The text was updated successfully, but these errors were encountered:
kanzelm3
added a commit
to kanzelm3/liquid-route
that referenced
this issue
Jul 15, 2017
@kanzelm3 i tested with the current routes, so the idea with reversing is to bring the DOM nodes back into initial position before they are removed. So the same animation can be applied.
Have you built a custom animator for your example?
If yes, can I have a look?
I'm curious why you added the reversed animation on exit animation finish: https://github.com/prateekbh/liquid-route/blob/master/Components/LiquidRoute/LiquidAnimator.jsx#L37
It is causing a bug for me where my route transition is messed up/reversed every other time it runs. I removed the reverse animation logic in
componentWillLeave
and it fixes the issue. Curious if anyone else is seeing this as it seems to be a pretty big bug. I'll go ahead and submit a PR.The text was updated successfully, but these errors were encountered: