Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation is reversed the second time it runs #3

Open
kanzelm3 opened this issue Jul 15, 2017 · 2 comments
Open

Animation is reversed the second time it runs #3

kanzelm3 opened this issue Jul 15, 2017 · 2 comments

Comments

@kanzelm3
Copy link
Contributor

I'm curious why you added the reversed animation on exit animation finish: https://github.com/prateekbh/liquid-route/blob/master/Components/LiquidRoute/LiquidAnimator.jsx#L37

It is causing a bug for me where my route transition is messed up/reversed every other time it runs. I removed the reverse animation logic in componentWillLeave and it fixes the issue. Curious if anyone else is seeing this as it seems to be a pretty big bug. I'll go ahead and submit a PR.

kanzelm3 added a commit to kanzelm3/liquid-route that referenced this issue Jul 15, 2017
@prateekbh
Copy link
Owner

merged 🎉 🎉 🎉 🎉

@prateekbh prateekbh reopened this Jul 18, 2017
@prateekbh
Copy link
Owner

@kanzelm3 i tested with the current routes, so the idea with reversing is to bring the DOM nodes back into initial position before they are removed. So the same animation can be applied.

Have you built a custom animator for your example?
If yes, can I have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants