Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subset object fails to encode if table data is empty #39

Closed
mojavelinux opened this issue Mar 26, 2017 · 2 comments
Closed

Subset object fails to encode if table data is empty #39

mojavelinux opened this issue Mar 26, 2017 · 2 comments

Comments

@mojavelinux
Copy link
Contributor

If the data in one of the tables is empty, the Subset object fails to encode. This bug was introduced when the checksum method was rewritten prior to 1.5.0.

See 129d423#diff-45b279937f00663adf564be8dead1e57L126

The method no longer accounts for a zero-length string. When the string is empty, the method returns false instead of 0.
mojavelinux added a commit to mojavelinux/ttfunk that referenced this issue Mar 26, 2017
@mojavelinux
resolves prawnpdf#39 change Subset#checksum method to return 0 for ze…
511c3fd 
…ro-length string
@mojavelinux
Copy link
Contributor Author

mojavelinux commented Mar 26, 2017 •
edited
Loading

This bug causes ttfunk to crash when working with many fonts. As a result, Prawn is unusable.

@mojavelinux mojavelinux changed the title Subset fails to encode if table data is empty Subset object fails to encode if table data is empty Mar 26, 2017
mojavelinux added a commit to asciidoctor/asciidoctor-pdf that referenced this issue Mar 26, 2017
@mojavelinux
add workaround for TTFunk bug when font table has empty data
bc40d35 
- apply patch for prawnpdf/ttfunk#39
- add case to chronicles-example.adoc that demonstrates problem
- remove comment about crash
@pointlessone
Copy link
Member

This is fixed in 1.5.1.

pointlessone pushed a commit that referenced this issue Apr 11, 2017
@mojavelinux @pointlessone
resolves #39 change Subset#checksum method to return 0 for zero-lengt…
3fea7c2 
…h string
@mojavelinux mojavelinux mentioned this issue Jan 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pointlessone @mojavelinux