Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct type from text to rst for rst-directive-colons hook #51

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Correct type from text to rst for rst-directive-colons hook #51

merged 1 commit into from
Feb 23, 2021

Conversation

CAM-Gerlach
Copy link
Contributor

Assign the correct types to the rst-directive-colons hook, ensuring it only triggers on rst files and categorizing it properly on the pre-commit hooks site list.

Fix #44

@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 23, 2021
Closed
asottile
asottile approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 63cb499 into pre-commit:master Feb 23, 2021
@CAM-Gerlach
Copy link
Contributor Author

Thanks @asottile !

@MarcoGorelli MarcoGorelli mentioned this pull request Feb 28, 2021
Merged
1 task
@CAM-Gerlach CAM-Gerlach mentioned this pull request Mar 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rst-directive-colons has type text instead of rst, unlike the other two rst hooks
2 participants
@CAM-Gerlach @asottile