Fix: Include ReadMe when publishing package #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d107596 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
developit
approved these changes
Sep 21, 2020
|
🦙! |
|
This Pr will also need a changeset, you can do so by running yarn changeset at the root |
rschristian
force-pushed
the
docs/cliReadme
branch
from
77a1e1e to
5df6226
Compare
rschristian
force-pushed
the
docs/cliReadme
branch
from
5df6226 to
d107596
Compare
ForsakenHarmony
approved these changes
Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix when publishing
Did you add tests for your changes?
No
Summary
Currently, the ReadMe is not included with the package when publishing it. This can be quite inconvenient as there's no documentation to go with the package.
It seems the last time the readme was included was back with
3.0.0-next.1. While there was an attempt to fix this with #806, it doesn't seem to have worked. I'm going to guess that this is because publishing happens from withpackages/clirather than the root.This moves the copy & clean up commands into the cli package itself.
Does this PR introduce a breaking change?
No