Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correcting create command finished instructions #1503

Merged

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

Bugfix

Did you add tests for your changes?

No

Summary

The CLI's create command is supposed to output some instructions to users upon completing. However, this is broken on the latest version, and looks to have been broken years ago. Was just hidden while everyone was still using 2.2.1 for their global installs.

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner December 18, 2020 08:24
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2020

🦋 Changeset detected

Latest commit: a90f0ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ForsakenHarmony
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2021
**What kind of change does this PR introduce?**

Bugfix

**Did you add tests for your changes?**

No

**Summary**

The CLI's `create` command is supposed to output some instructions to users upon completing. However, this is broken on the latest version, and looks to have been broken years ago. Was just hidden while everyone was still using `2.2.1` for their global installs. 

**Does this PR introduce a breaking change?**

No


Co-authored-by: Ryan Christian <[email protected]>
@ForsakenHarmony
Copy link
Member

bors retry

@bors
Copy link

bors bot commented Mar 8, 2021

Already running a review

@ForsakenHarmony
Copy link
Member

bors try-

@ForsakenHarmony
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Mar 8, 2021

Canceled.

@ForsakenHarmony
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2021
**What kind of change does this PR introduce?**

Bugfix

**Did you add tests for your changes?**

No

**Summary**

The CLI's `create` command is supposed to output some instructions to users upon completing. However, this is broken on the latest version, and looks to have been broken years ago. Was just hidden while everyone was still using `2.2.1` for their global installs. 

**Does this PR introduce a breaking change?**

No


Co-authored-by: Ryan Christian <[email protected]>
@ForsakenHarmony
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Mar 8, 2021

Canceled.

@ForsakenHarmony
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Mar 8, 2021

Configuration problem:
bors.toml: expected required_approvals to be an integer

@ForsakenHarmony
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 8, 2021
**What kind of change does this PR introduce?**

Bugfix

**Did you add tests for your changes?**

No

**Summary**

The CLI's `create` command is supposed to output some instructions to users upon completing. However, this is broken on the latest version, and looks to have been broken years ago. Was just hidden while everyone was still using `2.2.1` for their global installs. 

**Does this PR introduce a breaking change?**

No


Co-authored-by: Ryan Christian <[email protected]>
@ForsakenHarmony ForsakenHarmony merged commit 0e4f06a into preactjs:master Mar 8, 2021
@preact-bot preact-bot mentioned this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants