Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replacing mkdirp with native mkdir recursive #1504

Merged
merged 4 commits into from
Feb 25, 2021

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Dec 19, 2020

What kind of change does this PR introduce?

Refactor

Did you add tests for your changes?

No

Summary

Replaces uses of mkdirp with native mkdir with the recursive option. Same effect.

The recursive option came out in Node v10.12.0. As Node v10 is EOL in April and the current target is 12.0, mkdirp can be replaced.

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner December 19, 2020 06:06
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2020

🦋 Changeset detected

Latest commit: 5c4efc9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ForsakenHarmony ForsakenHarmony merged commit c9c48db into preactjs:master Feb 25, 2021
@preact-bot preact-bot mentioned this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants