fix: do not prompt on supplying template as an argument. #1527
Conversation
🦋 Changeset detectedLatest commit: 92667e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Definitely don't think we want to deprecate anything here. This would also be a major, not a minor, as all deprecations are. We just need to clean up the ambiguity/consistency between the docs and actual commands while also fixing that issue with the flag not existing. I don't think there's any need to break the existing behavior like this. |
jamesgeorge007
force-pushed
the
feat/create
branch
from
14fde87 to
c36c551
Compare
jamesgeorge007
force-pushed
the
feat/create
branch
from
c36c551 to
2cf31fb
Compare
jamesgeorge007
changed the title
|
I do agree with your original work and I think it's something we should look into, getting all of the commands a bit more consistent. It was just that a breaking change is so far away from being merge-able in all likelihood that it wouldn't solve the immediate issue of the flag not existing. I might end up copying your original commit over to a more long term PR where the API of the CLI can be more properly considered. |
What kind of change does this PR introduce?
patch
Did you add tests for your changes?
Nope
Summary
Supplying the
preactjs-templateas an argument doesn't show the respective prompt.#1523
Does this PR introduce a breaking change?
Nope
Other information
N/A