fix: Correcting SW flag in dev #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fae2269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
changed the title
| @@ -103,6 +117,38 @@ async function clientConfig(env) { | |||
| }, | |||
| ].filter(Boolean) | |||
| ), | |||
| ...(env.sw | |||
There was a problem hiding this comment.
this makes things a lot less readable
There was a problem hiding this comment.
The nested ternary?
Yeah, sorry, can't remember why I did it like that. I'll try to fix that up tomorrow (3am here)
There was a problem hiding this comment.
Pushed an update, hopefully that's more readable.
rschristian
force-pushed
the
fix/swOnDev
branch
from
fdff16d to
b3625ea
Compare
ForsakenHarmony
approved these changes
Mar 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
No
Summary
Running
yarn dev --swwould create an error thatprocesswas not defined. This is because there was noDefinePluginentry forprocess.env.ES_BUILDon dev. This was found here #1531 (comment)Upon adding that, the service worker would attempt to be installed but run into errors upon registering. The solution for that seems to be adding the
InjectManifestas a plugin, though this isn't ideal and throws a workbox warning (GoogleChrome/workbox#1790). Kinda seems like we just shouldn't support the non-debug SW during dev?Additionally, this still fails if ran with the
--esmflag, as nosw-esm.jsis generated in dev. But that's probably a separate issue.Does this PR introduce a breaking change?
No