Add support for rendering HTML comments #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e0a6e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is done via Fragments because they are the least common components. That way the additional branching has minimal impact
marvinhagemeister
force-pushed
the
comments
branch
from
a5dc77c to
659b456
Compare
JoviDeCroock
reviewed
Jun 7, 2023
JoviDeCroock
approved these changes
Jun 7, 2023
Co-authored-by: Jovi De Croock <[email protected]>
|
Marked the name as unstable as proposed in yesterday's call. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering HTML comments via
preact-render-to-string. Instead of adding a new vnode type this leveragesFragments. This has the benefit that branching cost is minimal asFragmentsare the least frequently used components and they sorta represent "nothing" in terms of client code.<Fragment UNSTABLE_comment="foobar" />renders<!--foobar-->. When the prop is present, all other children are ignored.This solves an issue with fresh which currently renders invalid HTML comments. Browsers happily parse over that, but it's annoying if you're testing with HTML validators on CI. See denoland/fresh#838