Improve nested effect rerenders in act (-49 B) #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `act` relies on a new internal option (`options.hooks`) to detect if a rerender queued up more effects to run. This PR removes `options.hooks` and instead detects if there are new effects to run by continuing to flush and rerender as long as `options.requestAnimationFrame` is invoked.
JoviDeCroock
approved these changes
Apr 17, 2019
marvinhagemeister
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
The bytes are always scared of @andrewiggins ! Really awesome work 👍 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
actrelies on a new internal option (options.hooks) to detect if a rerender queued up more effects to run. This PR removesoptions.hooksand instead detects if there are new effects to run by continuing to flush and rerender as long asoptions.requestAnimationFrameis invoked.