Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styled-components example #1574

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

marvinhagemeister
Copy link
Member

This PR adds a simple example page for styled-components.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 10d41d2 on styled_components_example into 41cbc43 on master.

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JoviDeCroock JoviDeCroock merged commit 3396e3e into master Apr 25, 2019
lordvlad added a commit to lordvlad/preact that referenced this pull request Apr 30, 2019
* upstream/master: (341 commits)
  Revert "Simplify originalDom check (-4 B)
"
  Simplify originalDom check (-4 B)
  Add back mistakenly removed JSDoc comment
  Remove unnecessary code from `diffChildren` (-16 B)
  Golf createContext (-6 B)
  Fix useContext test spacing
  Remove `dom` parameter from `diff()` (-11 B)
  Move all component diff'ing logic into component diff condition (-6 B)
  fix issue by marking dirty before .render since this can potentially add another entry on the render queue
  add relevant test
  (chore) - remove focusElement (preactjs#1548)
  Update type definition (preactjs#1581)
  Compress code, assume EMPTY_OBJ._children == null
  Refactor out variables from diffChildren
  Compress diffChildren further
  Compress diffChildren further
  Condense code in diffChildren
  Fix infinite loop because of props mutation (preactjs#1577)
  (fix) - Error boundary not applying in array cases (preactjs#1572)
  Add styled-components example (preactjs#1574)
  ...

# Conflicts:
#	.eslintignore
#	compat/mangle.json
#	compat/src/index.js
#	compat/src/internal.d.ts
#	debug/mangle.json
#	hooks/src/index.d.ts
#	hooks/src/index.js
#	hooks/src/internal.d.ts
#	mangle.json
#	package.json
#	src/component.js
#	src/constants.js
#	src/create-context.js
#	src/create-element.js
#	src/diff/children.js
#	src/diff/index.js
#	src/diff/props.js
#	src/index.d.ts
#	src/internal.d.ts
#	src/jsx.d.ts
#	src/render.js
#	src/util.js
@marvinhagemeister marvinhagemeister deleted the styled_components_example branch January 2, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants