Merge branch 'master' into restructure #3023

andrewiggins · 2021-02-15T22:21:55Z

Weekly merge from master

…ly render null

fix reordering issue of memoized component when the component initially render null

The watch feature now uses esbuild's new built in watch capabilities instead of spawning a chokidar instance. This leads to less CPU usage

Update esbuild + karma-esbuild

…unt (#2919) * use options.unmount instead of overriding component.componentWillUnmount * add test cases, allow hydrated suspended component can be unmounted

Upgrade tachometer and add script to analyze browser trace logs

Add support for rendering bigints

See: - marvinhagemeister/karma-esbuild#4 - marvinhagemeister/karma-esbuild#3

Tests: Fix stale watch cache

Reduce redundant preparation in bench scripts

github-actions · 2021-02-15T22:22:10Z

📊 Tachometer Benchmark Results

Summary

duration

02_replace1k: unsure 🔍 -4% - +4% (-7.57ms - +8.58ms)
^{preact-local vs preact-master}
03_update10th1k_x16: unsure 🔍 -5% - +5% (-1.77ms - +1.74ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -0% - +1% (-5.00ms - +16.67ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 -5% - +0% (-1.29ms - +0.02ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -3% - +2% (-2.86ms - +1.92ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -9% - +0% (-3.38ms - +0.06ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 -4% - +5% (-0.13ms - +0.16ms)
^{preact-local vs preact-master}

usedJSHeapSize

02_replace1k: slower ❌ 0% - 1% (0.00ms - 0.02ms)
^{preact-local vs preact-master}
03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
^{preact-local vs preact-master}
07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
filter_list: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}
hydrate1k: unsure 🔍 -0% - -0% (-0.01ms - -0.01ms)
^{preact-local vs preact-master}
many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-master}
text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-master}

Results

02_replace1k

Browser: chrome-headless 88.0.4324.150
Sample size: 80
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	203.86ms - 215.70ms	-	unsure 🔍 -4% - +4% -8.58ms - +7.57ms
preact-local	204.80ms - 215.77ms	unsure 🔍 -4% - +4% -7.57ms - +8.58ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.52ms - 3.53ms	-	faster ✔ 0% - 1% 0.00ms - 0.02ms
preact-local	3.53ms - 3.54ms	slower ❌ 0% - 1% 0.00ms - 0.02ms	-

run-warmup-0

Version	Avg time	vs preact-master	vs preact-local
preact-master	62.21ms - 64.30ms	-	unsure 🔍 -3% - +2% -1.87ms - +1.12ms
preact-local	62.57ms - 64.70ms	unsure 🔍 -2% - +3% -1.12ms - +1.87ms	-

run-warmup-1

Version	Avg time	vs preact-master	vs preact-local
preact-master	100.74ms - 104.26ms	-	unsure 🔍 -2% - +2% -2.40ms - +2.12ms
preact-local	101.22ms - 104.05ms	unsure 🔍 -2% - +2% -2.12ms - +2.40ms	-

run-warmup-2

Version	Avg time	vs preact-master	vs preact-local
preact-master	89.96ms - 100.01ms	-	unsure 🔍 -7% - +8% -6.56ms - +7.76ms
preact-local	89.29ms - 99.48ms	unsure 🔍 -8% - +7% -7.76ms - +6.56ms	-

run-warmup-3

Version	Avg time	vs preact-master	vs preact-local
preact-master	84.84ms - 99.01ms	-	unsure 🔍 -12% - +9% -11.24ms - +8.75ms
preact-local	86.11ms - 100.22ms	unsure 🔍 -10% - +12% -8.75ms - +11.24ms	-

run-warmup-4

Version	Avg time	vs preact-master	vs preact-local
preact-master	84.21ms - 92.88ms	-	unsure 🔍 -9% - +5% -8.01ms - +4.55ms
preact-local	85.73ms - 94.82ms	unsure 🔍 -5% - +9% -4.55ms - +8.01ms	-

run-final

Version	Avg time	vs preact-master	vs preact-local
preact-master	85.20ms - 93.40ms	-	unsure 🔍 -8% - +4% -7.68ms - +3.97ms
preact-local	87.02ms - 95.29ms	unsure 🔍 -5% - +9% -3.97ms - +7.68ms	-

03_update10th1k_x16

Browser: chrome-headless 88.0.4324.150
Sample size: 50
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	35.55ms - 38.03ms	-	unsure 🔍 -5% - +5% -1.74ms - +1.77ms
preact-local	35.53ms - 38.01ms	unsure 🔍 -5% - +5% -1.77ms - +1.74ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.47ms - 3.47ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.01ms
preact-local	3.47ms - 3.47ms	unsure 🔍 -0% - +0% -0.01ms - +0.01ms	-

07_create10k

Browser: chrome-headless 88.0.4324.150
Sample size: 50
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	1355.12ms - 1369.37ms	-	unsure 🔍 -1% - +0% -16.67ms - +5.00ms
preact-local	1359.92ms - 1376.24ms	unsure 🔍 -0% - +1% -5.00ms - +16.67ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	25.35ms - 25.36ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	25.36ms - 25.36ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter_list

Browser: chrome-headless 88.0.4324.150
Sample size: 80
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	26.89ms - 27.96ms	-	unsure 🔍 -0% - +5% -0.02ms - +1.29ms
preact-local	26.42ms - 27.17ms	unsure 🔍 -5% - +0% -1.29ms - +0.02ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	1.61ms - 1.61ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	1.61ms - 1.61ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

hydrate1k

Browser: chrome-headless 88.0.4324.150
Sample size: 50
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	105.16ms - 108.45ms	-	unsure 🔍 -2% - +3% -1.92ms - +2.86ms
preact-local	104.61ms - 108.07ms	unsure 🔍 -3% - +2% -2.86ms - +1.92ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	5.93ms - 5.93ms	-	unsure 🔍 +0% - +0% +0.01ms - +0.01ms
preact-local	5.92ms - 5.92ms	unsure 🔍 -0% - -0% -0.01ms - -0.01ms	-

many_updates

Browser: chrome-headless 88.0.4324.150
Sample size: 80
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	36.56ms - 39.18ms	-	unsure 🔍 -0% - +9% -0.06ms - +3.38ms
preact-local	35.09ms - 37.33ms	unsure 🔍 -9% - +0% -3.38ms - +0.06ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	4.76ms - 4.76ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-local	4.76ms - 4.76ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

text_update

Browser: chrome-headless 88.0.4324.150
Sample size: 120
Built by: Benchmarks #105
Commit: 0466d08

duration

Version	Avg time	vs preact-master	vs preact-local
preact-master	3.48ms - 3.63ms	-	unsure 🔍 -5% - +4% -0.16ms - +0.13ms
preact-local	3.44ms - 3.69ms	unsure 🔍 -4% - +5% -0.13ms - +0.16ms	-

usedJSHeapSize

Version	Avg time	vs preact-master	vs preact-local
preact-master	0.83ms - 0.83ms	-	unsure 🔍 -0% - -0% -0.00ms - -0.00ms
preact-local	0.83ms - 0.83ms	unsure 🔍 +0% - +0% +0.00ms - +0.00ms	-

_{tachometer-reporter-action v2 for Benchmarks}

coveralls · 2021-02-15T22:24:16Z

Coverage increased (+0.005%) to 99.269% when pulling 0466d08 on restructure-master into a70abee on restructure.

github-actions · 2021-02-15T22:24:41Z

Size Change: +173 B (0%)

Total Size: 43.4 kB

Filename	Size	Change
`compat/dist/compat.js`	3.5 kB	+25 B (0%)
`compat/dist/compat.module.js`	3.51 kB	+23 B (0%)
`compat/dist/compat.umd.js`	3.55 kB	+23 B (0%)
`dist/preact.js`	4.25 kB	+25 B (0%)
`dist/preact.min.js`	4.28 kB	+26 B (0%)
`dist/preact.module.js`	4.26 kB	+26 B (0%)
`dist/preact.umd.js`	4.32 kB	+25 B (0%)

ℹ️ View Unchanged

Filename	Size	Change
`debug/dist/debug.js`	2.99 kB	0 B
`debug/dist/debug.module.js`	2.98 kB	0 B
`debug/dist/debug.umd.js`	3.07 kB	0 B
`devtools/dist/devtools.js`	232 B	0 B
`devtools/dist/devtools.module.js`	241 B	0 B
`devtools/dist/devtools.umd.js`	308 B	0 B
`hooks/dist/hooks.js`	1.13 kB	0 B
`hooks/dist/hooks.module.js`	1.15 kB	0 B
`hooks/dist/hooks.umd.js`	1.2 kB	0 B
`jsx-runtime/dist/jsxRuntime.js`	325 B	0 B
`jsx-runtime/dist/jsxRuntime.module.js`	335 B	0 B
`jsx-runtime/dist/jsxRuntime.umd.js`	406 B	0 B
`test-utils/dist/testUtils.js`	437 B	0 B
`test-utils/dist/testUtils.module.js`	439 B	0 B
`test-utils/dist/testUtils.umd.js`	515 B	0 B

_{compressed-size-action}

andrewiggins · 2021-02-16T00:35:52Z

I have one more PR (#3024) that I'd like to get in before doing this merge

Create separate trace log directories per benchmark

tanhauhau and others added 21 commits February 8, 2021 16:19

fix reordering issue of memoized component when the component initial…

76fc28b

…ly render null

Merge branch 'master' into tanhauhau/fix-memo-reorder

1509959

Merge pull request #2988 from tanhauhau/tanhauhau/fix-memo-reorder

700529f

fix reordering issue of memoized component when the component initially render null

Update esbuild + karma-esbuild

460ce62

The watch feature now uses esbuild's new built in watch capabilities instead of spawning a chokidar instance. This leads to less CPU usage

Merge pull request #2991 from preactjs/esbuild-watch

3efb2d0

Update esbuild + karma-esbuild

use options.unmount instead of overriding component.componentWillUnmo…

9250ac9

…unt (#2919) * use options.unmount instead of overriding component.componentWillUnmount * add test cases, allow hydrated suspended component can be unmounted

Add --trace flag to bench scripts

5c54453

Add script to analyze chromium trace logs

169eea1

Merge pull request #3005 from preactjs/trace-benchmarks

c123310

Upgrade tachometer and add script to analyze browser trace logs

Tests: Fix Chrome 88 stack traces displayed wrong in terminal

5056f1b

Add support for rendering bigints

8d9354c

Merge pull request #3010 from preactjs/bigint

dcdc32a

Add support for rendering bigints

Merge branch 'master' into karma-stack-traces

f99902d

Merge pull request #3008 from preactjs/karma-stack-traces

6c263a8

Update karma-esbuild to reduce CPU usage in watch mode

13468ee

See: - marvinhagemeister/karma-esbuild#4 - marvinhagemeister/karma-esbuild#3

Merge pull request #3011 from preactjs/karma-esbuild-update

afe46b4

Tests: Fix stale watch cache

85c1f41

Merge pull request #3012 from preactjs/karma-esbuild-upgrade

2b955fc

Tests: Fix stale watch cache

Reduce redundant preparation in bench scripts

a27f878

Merge pull request #3013 from preactjs/improve-benching-scripts

5c594fd

Reduce redundant preparation in bench scripts

Merge branch 'master' into restructure-master

91bb7f0

andrewiggins marked this pull request as draft February 16, 2021 00:35

andrewiggins added 2 commits February 15, 2021 16:46

Create separate trace log directories per benchmark

7475566

Print helpful message if no benchmarks are found matching patterns

0f88fac

marvinhagemeister approved these changes Feb 16, 2021

View reviewed changes

Merge pull request #3024 from preactjs/log-dir-per-bench

b396932

Create separate trace log directories per benchmark

Merge branch 'master' into restructure-master

0466d08

marvinhagemeister approved these changes Feb 16, 2021

View reviewed changes

andrewiggins marked this pull request as ready for review February 16, 2021 05:57

andrewiggins merged commit 0a1e937 into restructure Feb 16, 2021

andrewiggins deleted the restructure-master branch February 16, 2021 05:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge branch 'master' into restructure #3023

Merge branch 'master' into restructure #3023

andrewiggins commented Feb 15, 2021

github-actions bot commented Feb 15, 2021 •

edited

Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Feb 15, 2021 •

edited

Loading

github-actions bot commented Feb 15, 2021 •

edited

Loading

andrewiggins commented Feb 16, 2021 •

edited

Loading

Merge branch 'master' into restructure #3023

Merge branch 'master' into restructure #3023

Conversation

andrewiggins commented Feb 15, 2021

github-actions bot commented Feb 15, 2021 • edited Loading

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

coveralls commented Feb 15, 2021 • edited Loading

github-actions bot commented Feb 15, 2021 • edited Loading

andrewiggins commented Feb 16, 2021 • edited Loading

github-actions bot commented Feb 15, 2021 •

edited

Loading

coveralls commented Feb 15, 2021 •

edited

Loading

github-actions bot commented Feb 15, 2021 •

edited

Loading

andrewiggins commented Feb 16, 2021 •

edited

Loading