Revert handle event

[JoviDeCroock]

Resolves #4581
Reverts #4538

After trying to fix this for a while this looks like it's just incompatible with our current ecosystem and would warrant a breaking change, my sincerest apologies for backtracking on this. I've added a test in the TS tests to avoid this in the future.

There's an inherent incompatibility with using the handleEvent interface as these types are also used by our consumers to type their events and components.

[github-actions]

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

• create10k: unsure 🔍 -0% - +0% (-3.25ms - +4.58ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -3% - +1% (-0.51ms - +0.25ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -1% - +1% (-0.54ms - +1.04ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -2% - +5% (-0.27ms - +0.77ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +1% (-0.59ms - +0.97ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -6% - +2% (-0.15ms - +0.05ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -3% - +3% (-0.96ms - +0.93ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -2% - +3% (-0.68ms - +0.98ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -2% - +0% (-0.03ms - +0.00ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -6% - +0% (-0.90ms - +0.07ms)
  ^{preact-local vs preact-main}
• many-updates: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -1% - +0% (-0.04ms - +0.01ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: unsure 🔍 -0% - +1% (-0.00ms - +0.02ms)
  ^{preact-local vs preact-main}

Results

⏳ Benchmarks are currently running. Results below are out of date.

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	925.72ms - 930.95ms	-	unsure 🔍 -0% - +0% -3.25ms - +4.58ms
preact-main	924.76ms - 930.58ms	unsure 🔍 -0% - +0% -4.58ms - +3.25ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.84ms - 24.84ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	24.84ms - 24.84ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.50ms - 16.76ms	-	unsure 🔍 -3% - +1% -0.51ms - +0.25ms
preact-main	16.41ms - 17.12ms	unsure 🔍 -1% - +3% -0.25ms - +0.51ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.64ms - 1.66ms	-	unsure 🔍 -2% - +0% -0.03ms - +0.00ms
preact-main	1.65ms - 1.68ms	unsure 🔍 -0% - +2% -0.00ms - +0.03ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	72.37ms - 73.65ms	-	unsure 🔍 -1% - +1% -0.54ms - +1.04ms
preact-main	72.30ms - 73.22ms	unsure 🔍 -1% - +1% -1.04ms - +0.54ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	13.48ms - 14.12ms	-	unsure 🔍 -6% - +0% -0.90ms - +0.07ms
preact-main	13.85ms - 14.58ms	unsure 🔍 -1% - +7% -0.07ms - +0.90ms	-

many-updates

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.15ms - 16.90ms	-	unsure 🔍 -2% - +5% -0.27ms - +0.77ms
preact-main	15.92ms - 16.63ms	unsure 🔍 -5% - +2% -0.77ms - +0.27ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.49ms - 4.50ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-main	4.49ms - 4.51ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

replace1k

• Browser: chrome-headless
• Sample size: 90
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.13ms - 69.22ms	-	unsure 🔍 -1% - +1% -0.59ms - +0.97ms
preact-main	67.93ms - 69.05ms	unsure 🔍 -1% - +1% -0.97ms - +0.59ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.56ms - 3.59ms	-	unsure 🔍 -1% - +0% -0.04ms - +0.01ms
preact-main	3.57ms - 3.61ms	unsure 🔍 -0% - +1% -0.01ms - +0.04ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.68ms - 31.53ms	-	unsure 🔍 -3% - +1% -0.92ms - +0.23ms
preact-main	31.06ms - 31.84ms	unsure 🔍 -1% - +3% -0.23ms - +0.92ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	36.28ms - 37.83ms	-	unsure 🔍 -4% - +2% -1.41ms - +0.84ms
preact-main	36.53ms - 38.15ms	unsure 🔍 -2% - +4% -0.84ms - +1.41ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.62ms - 31.66ms	-	unsure 🔍 -2% - +2% -0.73ms - +0.71ms
preact-main	30.65ms - 31.65ms	unsure 🔍 -2% - +2% -0.71ms - +0.73ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.17ms - 23.69ms	-	unsure 🔍 -3% - +1% -0.68ms - +0.17ms
preact-main	23.34ms - 24.02ms	unsure 🔍 -1% - +3% -0.17ms - +0.68ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	21.97ms - 22.25ms	-	unsure 🔍 -1% - +1% -0.22ms - +0.17ms
preact-main	21.99ms - 22.27ms	unsure 🔍 -1% - +1% -0.17ms - +0.22ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	20.71ms - 21.42ms	-	unsure 🔍 -2% - +2% -0.45ms - +0.50ms
preact-main	20.71ms - 21.36ms	unsure 🔍 -2% - +2% -0.50ms - +0.45ms	-

text-update

• Browser: chrome-headless
• Sample size: 220
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.14ms - 2.27ms	-	unsure 🔍 -6% - +2% -0.15ms - +0.05ms
preact-main	2.17ms - 2.32ms	unsure 🔍 -2% - +7% -0.05ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.10ms - 1.11ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.01ms
preact-main	1.10ms - 1.11ms	unsure 🔍 -1% - +0% -0.01ms - +0.00ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.43ms - 35.86ms	-	unsure 🔍 -3% - +3% -0.96ms - +0.93ms
preact-main	34.54ms - 35.78ms	unsure 🔍 -3% - +3% -0.93ms - +0.96ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.22ms - 1.22ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.22ms - 1.22ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #4120

• Commit: 8d06f28

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.37ms - 34.50ms	-	unsure 🔍 -2% - +3% -0.68ms - +0.98ms
preact-main	33.17ms - 34.39ms	unsure 🔍 -3% - +2% -0.98ms - +0.68ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.47ms - 3.50ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.02ms
preact-main	3.47ms - 3.48ms	unsure 🔍 -1% - +0% -0.02ms - +0.00ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: -89 B (-0.14%)

Total Size: 62.5 kB

Filename	Size	Change
dist/preact.js	4.73 kB	-14 B (-0.3%)
dist/preact.min.js	4.75 kB	-15 B (-0.31%)
dist/preact.min.module.js	4.75 kB	-18 B (-0.38%)
dist/preact.min.umd.js	4.77 kB	-15 B (-0.31%)
dist/preact.module.js	4.75 kB	-14 B (-0.29%)
dist/preact.umd.js	4.79 kB	-13 B (-0.27%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	4.13 kB
compat/dist/compat.module.js	4.06 kB
compat/dist/compat.umd.js	4.2 kB
debug/dist/debug.js	3.82 kB
debug/dist/debug.module.js	3.83 kB
debug/dist/debug.umd.js	3.9 kB
devtools/dist/devtools.js	260 B
devtools/dist/devtools.module.js	274 B
devtools/dist/devtools.umd.js	346 B
hooks/dist/hooks.js	1.52 kB
hooks/dist/hooks.module.js	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	973 B
jsx-runtime/dist/jsxRuntime.module.js	947 B
jsx-runtime/dist/jsxRuntime.umd.js	1.05 kB
test-utils/dist/testUtils.js	451 B
test-utils/dist/testUtils.module.js	456 B
test-utils/dist/testUtils.umd.js	536 B

_{compressed-size-action}

[coveralls]

coverage: 99.617%. remained the same
when pulling d4d4363 on revert-handle-event
into 99e5e04 on main.

[lilnasy]

Ah that's unfortunate, but I think it's for the best, and it isn't too late.

rschristian is working on prop and attr directives. This could be reintroduced with a directive as well. As a bonus, that will be visually consistent with solid, and unlock #428.