Adjust ReadOnlySignal so we cant widen the type #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57ab3de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: 0 B Total Size: 83 kB ℹ️ View Unchanged
|
JoviDeCroock
force-pushed
the
avoid-readonly-inheritance
branch
from
8be3c70 to
703dcb4
Compare
JoviDeCroock
commented
Aug 2, 2024
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| "@preact/signals-core": minor | |||
There was a problem hiding this comment.
This might need to be a major though 😅
There was a problem hiding this comment.
Minor for a type correction is completely a-ok, IMO.
There was a problem hiding this comment.
I'll expand on the changeset then to provide our reasoning to avoid excessive issues about it
JoviDeCroock
force-pushed
the
avoid-readonly-inheritance
branch
from
703dcb4 to
2a9febb
Compare
rschristian
approved these changes
Aug 3, 2024
JoviDeCroock
force-pushed
the
avoid-readonly-inheritance
branch
from
2a9febb to
57ab3de
Compare
marvinhagemeister
approved these changes
Aug 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid inheriting from signal in ReadonlySignal so we can't accidentally widen the type by doing
const computed: Signal<any> = useComputed(() => {}), in widening this type we would lose thereadonlyaspect of the value property effectively making it a mutable signal.Fixes #585