Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure sourcemap sourcesContent exists before trying to consume #927

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented May 1, 2022

Closes #926

Per the spec, sourcesContent is optional so we need to check for its existence before consuming.

@changeset-bot
Copy link

changeset-bot bot commented May 1, 2022

🦋 Changeset detected

Latest commit: 2c251f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wmr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rschristian rschristian changed the title Fix/sourcemap sources content fix: Ensure sourcemap sourcesContent exists before trying to consume May 1, 2022
@rschristian rschristian force-pushed the fix/sourcemap-sources-content branch from 69d2739 to 2c5e58a Compare August 16, 2022 05:33
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

Size Change: 0 B

Total Size: 805 kB

ℹ️ View Unchanged
Filename Size
examples/demo/dist/about/index.html 720 B
examples/demo/dist/alias-outside/index.html 697 B
examples/demo/dist/assets/Calendar.********.css 694 B
examples/demo/dist/assets/style.********.css 624 B
examples/demo/dist/chunks/alias-outside.********.js 139 B
examples/demo/dist/chunks/class-fields.********.js 211 B
examples/demo/dist/chunks/compat.********.js 16.9 kB
examples/demo/dist/chunks/hoofd.module.********.js 1.48 kB
examples/demo/dist/chunks/index.********.js 303 B
examples/demo/dist/chunks/json.********.js 238 B
examples/demo/dist/chunks/meta-tags.********.js 298 B
examples/demo/dist/chunks/prerender.********.js 294 B
examples/demo/dist/class-fields/index.html 709 B
examples/demo/dist/compat/index.html 1.56 kB
examples/demo/dist/env/index.html 786 B
examples/demo/dist/error/index.html 714 B
examples/demo/dist/files/index.html 743 B
examples/demo/dist/index.********.js 8.2 kB
examples/demo/dist/index.html 775 B
examples/demo/dist/json/index.html 720 B
examples/demo/dist/lazy-and-late/index.html 723 B
examples/demo/dist/meta-tags/index.html 789 B
packages/wmr/wmr.cjs 767 kB

compressed-size-action

@rschristian rschristian force-pushed the fix/sourcemap-sources-content branch from 2c5e58a to 2c251f0 Compare September 26, 2022 22:59
@rschristian rschristian merged commit d5d8fff into main Sep 26, 2022
@rschristian rschristian deleted the fix/sourcemap-sources-content branch September 26, 2022 23:18
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@mdx-js/rollup plugin doesn't work in development mode
2 participants