SmartRTB Bid Adapter: add alias and update valid opts (#6365)

* Add alias, update valid opts * Update bidder tests
prebid · Mar 10, 2021 · cdfc9df · cdfc9df
1 parent b65ea73
commit cdfc9df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/modules/smartrtbBidAdapter.js b/modules/smartrtbBidAdapter.js
@@ -17,11 +17,9 @@ function getDomain () {
 export const spec = {
   code: BIDDER_CODE,
   supportedMediaTypes: [ 'banner', 'video' ],
-  aliases: ['smrtb'],
+  aliases: ['rdigital'],
   isBidRequestValid: function(bid) {
-    return (bid.params.pubId !== null &&
-      bid.params.medId !== null &&
-      bid.params.zoneId !== null);
+    return (bid.params.pubId !== null || bid.params.zoneId !== null);
   },
   buildRequests: function(validBidRequests, bidderRequest) {
     let stack = (bidderRequest.refererInfo &&

diff --git a/test/spec/modules/smartrtbBidAdapter_spec.js b/test/spec/modules/smartrtbBidAdapter_spec.js
@@ -69,18 +69,15 @@ describe('SmartRTBBidAdapter', function () {
     it('should return a bidder code of smartrtb', function () {
       expect(spec.code).to.equal('smartrtb')
     })
-    it('should alias smrtb', function () {
-      expect(spec.aliases.length > 0 && spec.aliases[0] === 'smrtb').to.be.true
-    })
   })
 
   describe('isBidRequestValid', function () {
     it('should return true if all params present', function () {
       expect(spec.isBidRequestValid(bannerRequest)).to.be.true
     })
 
-    it('should return false if any zone id missing', function () {
-      expect(spec.isBidRequestValid(Object.assign(bannerRequest, { params: { zoneId: null } }))).to.be.false
+    it('should return false if any zone id and pub id missing', function () {
+      expect(spec.isBidRequestValid(Object.assign(bannerRequest, { params: { pubId: null, zoneId: null } }))).to.be.false
     })
   })