Skip to content

Commit

Permalink
Incorrect atypes on various eids (#6477)
Browse files Browse the repository at this point in the history 
* Update eids.js

* Update eids_spec.js

* Update eids.js

* Update pubmaticBidAdapter_spec.js

* Update eids.js

* Update eids_spec.js

* Update conversantBidAdapter_spec.js

* Update rubiconBidAdapter_spec.js

* Update conversantBidAdapter_spec.js

* Delete test/spec/adapters directory

* Update userId_spec.js
  • Loading branch information
@patmmccann
patmmccann authored Mar 29, 2021
1 parent 7d76822 commit d2e5956
Show file tree
Hide file tree
Showing 7 changed files with 24 additions and 24 deletions.
10 changes: 5 additions & 5 deletions modules/userId/eids.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const USER_IDS_CONFIG = {
// identityLink
'idl_env': {
source: 'liveramp.com',
atype: 1
atype: 3
},

// liveIntentId
Expand All @@ -80,7 +80,7 @@ const USER_IDS_CONFIG = {
return data.lipbid;
},
source: 'liveintent.com',
atype: 1,
atype: 3,
getEidExt: function(data) {
if (Array.isArray(data.segments) && data.segments.length) {
return {
Expand All @@ -93,7 +93,7 @@ const USER_IDS_CONFIG = {
// britepoolId
'britepoolid': {
source: 'britepool.com',
atype: 1
atype: 3
},

// lotamePanoramaId
Expand All @@ -111,7 +111,7 @@ const USER_IDS_CONFIG = {
// merkleId
'merkleId': {
source: 'merkleinc.com',
atype: 1
atype: 3
},

// NetId
Expand Down Expand Up @@ -161,7 +161,7 @@ const USER_IDS_CONFIG = {
// Verizon Media ConnectID
'connectid': {
source: 'verizonmedia.com',
atype: 1
atype: 3
},

// Neustar Fabrick
Expand Down
Empty file removed test/spec/adapters/adbutler_spec.js
View file
Empty file.
2 changes: 1 addition & 1 deletion test/spec/modules/conversantBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ describe('Conversant adapter tests', function() {
const payload = spec.buildRequests(requests).data;
expect(payload).to.have.deep.nested.property('user.ext.eids', [
{source: 'adserver.org', uids: [{id: '223344', atype: 1, ext: {rtiPartner: 'TDID'}}]},
{source: 'liveramp.com', uids: [{id: '334455', atype: 1}]}
{source: 'liveramp.com', uids: [{id: '334455', atype: 3}]}
]);
});
});
Expand Down
10 changes: 5 additions & 5 deletions test/spec/modules/eids_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'merkleinc.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -102,7 +102,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -117,7 +117,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'some-random-id-value', atype: 1}],
uids: [{id: 'some-random-id-value', atype: 3}],
ext: {segments: ['s1', 's2']}
});
});
Expand All @@ -132,7 +132,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand All @@ -144,7 +144,7 @@ describe('eids array generation for known sub-modules', function() {
expect(newEids.length).to.equal(1);
expect(newEids[0]).to.deep.equal({
source: 'britepool.com',
uids: [{id: 'some-random-id-value', atype: 1}]
uids: [{id: 'some-random-id-value', atype: 3}]
});
});

Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/pubmaticBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1695,7 +1695,7 @@ describe('PubMatic adapter', function () {
'source': 'liveramp.com',
'uids': [{
'id': 'identity-link-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down Expand Up @@ -1736,7 +1736,7 @@ describe('PubMatic adapter', function () {
'source': 'liveintent.com',
'uids': [{
'id': 'live-intent-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down Expand Up @@ -1818,7 +1818,7 @@ describe('PubMatic adapter', function () {
'source': 'britepool.com',
'uids': [{
'id': 'britepool-user-id',
'atype': 1
'atype': 3
}]
}]);
});
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/rubiconBidAdapter_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1498,15 +1498,15 @@ describe('the rubicon adapter', function () {
// LiveIntent should exist
expect(post.user.ext.eids[0].source).to.equal('liveintent.com');
expect(post.user.ext.eids[0].uids[0].id).to.equal('0000-1111-2222-3333');
expect(post.user.ext.eids[0].uids[0].atype).to.equal(1);
expect(post.user.ext.eids[0].uids[0].atype).to.equal(3);
expect(post.user.ext.eids[0]).to.have.property('ext').that.is.an('object');
expect(post.user.ext.eids[0].ext).to.have.property('segments').that.is.an('array');
expect(post.user.ext.eids[0].ext.segments[0]).to.equal('segA');
expect(post.user.ext.eids[0].ext.segments[1]).to.equal('segB');
// LiveRamp should exist
expect(post.user.ext.eids[1].source).to.equal('liveramp.com');
expect(post.user.ext.eids[1].uids[0].id).to.equal('1111-2222-3333-4444');
expect(post.user.ext.eids[1].uids[0].atype).to.equal(1);
expect(post.user.ext.eids[1].uids[0].atype).to.equal(3);
// SharedId should exist
expect(post.user.ext.eids[2].source).to.equal('sharedid.org');
expect(post.user.ext.eids[2].uids[0].id).to.equal('1111');
Expand Down
16 changes: 8 additions & 8 deletions test/spec/modules/userId_spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ describe('User ID', function () {
expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}]
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}]
});
});
});
Expand All @@ -965,7 +965,7 @@ describe('User ID', function () {
expect(bid.userId.idl_env).to.equal('AiGNC8Z5ONyZKSpIPf');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveramp.com',
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 1}]
uids: [{id: 'AiGNC8Z5ONyZKSpIPf', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1035,7 +1035,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.lipbid).to.equal('random-ls-identifier');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-ls-identifier', atype: 1}]
uids: [{id: 'random-ls-identifier', atype: 3}]
});
});
});
Expand All @@ -1059,7 +1059,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.lipbid).to.equal('random-cookie-identifier');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-cookie-identifier', atype: 1}]
uids: [{id: 'random-cookie-identifier', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1443,7 +1443,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.segments).to.include('123');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-ls-identifier', atype: 1}],
uids: [{id: 'random-ls-identifier', atype: 3}],
ext: {segments: ['123']}
});
});
Expand Down Expand Up @@ -1472,7 +1472,7 @@ describe('User ID', function () {
expect(bid.userId.lipb.segments).to.include('123');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'liveintent.com',
uids: [{id: 'random-cookie-identifier', atype: 1}],
uids: [{id: 'random-cookie-identifier', atype: 3}],
ext: {segments: ['123']}
});
});
Expand All @@ -1497,7 +1497,7 @@ describe('User ID', function () {
expect(bid.userId.britepoolid).to.equal('279c0161-5152-487f-809e-05d7f7e653fd');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'britepool.com',
uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 1}]
uids: [{id: '279c0161-5152-487f-809e-05d7f7e653fd', atype: 3}]
});
});
});
Expand Down Expand Up @@ -1595,7 +1595,7 @@ describe('User ID', function () {
expect(bid.userId.merkleId).to.equal('testmerkleId');
expect(bid.userIdAsEids[0]).to.deep.equal({
source: 'merkleinc.com',
uids: [{id: 'testmerkleId', atype: 1}]
uids: [{id: 'testmerkleId', atype: 3}]
});
});
});
Expand Down

0 comments on commit d2e5956

Please sign in to comment.