explicitly check undefined to allow falsey values in getConfig (#4486)

prebid · Nov 25, 2019 · e964dbb · e964dbb
1 parent 29a544c
commit e964dbb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/config.js b/src/config.js
@@ -221,9 +221,9 @@ export function newConfig() {
       const configTopicSet = new Set(Object.keys(config).concat(Object.keys(currBidderConfig)));
 
       return from(configTopicSet).reduce((memo, topic) => {
-        if (!currBidderConfig[topic]) {
+        if (typeof currBidderConfig[topic] === 'undefined') {
           memo[topic] = config[topic];
-        } else if (!config[topic]) {
+        } else if (typeof config[topic] === 'undefined') {
           memo[topic] = currBidderConfig[topic];
         } else {
           if (utils.isPlainObject(currBidderConfig[topic])) {

diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js
@@ -193,7 +193,7 @@ describe('adapterManager tests', function () {
         bidders: [ 'rubicon' ],
         config: {
           buildRequests: 'rubiconBuild',
-          interpretResponse: 'rubiconInterpret'
+          interpretResponse: null
         }
       });
       config.setBidderConfig({
@@ -230,7 +230,7 @@ describe('adapterManager tests', function () {
             'rubiconBuild',
             { speedy: true },
             { amazing: true },
-            'rubiconInterpret',
+            null,
             'anotherBaseInterpret'
           ]
         });