Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parrable User Id Submodule param "partners" #4316

Closed
pm-harshad-mane opened this issue Oct 16, 2019 · 2 comments
Closed

Parrable User Id Submodule param "partners" #4316

pm-harshad-mane opened this issue Oct 16, 2019 · 2 comments

Comments

@pm-harshad-mane
Copy link
Contributor

Type of issue

Probable documentation issue with Parrable User Id sub-module:

https://github.com/prebid/Prebid.js/blob/master/modules/userId/userId.md mentions a Parrable User Id sub-module parameter partners with data type array.
But in code, I see mention of a parameter named partner which seems to be consistent in other references and documentation.
Refer: https://github.com/prebid/Prebid.js/blob/master/modules/parrableIdSystem.js#L19

@eyas-ranjous
Copy link
Contributor

hi @pm-harshad-mane thanks for spotting this.

it was forgotten as an old implementation we had before we pushed our PR. I pushed a fix for it. here #4317

Cheers.

@bretg
Copy link
Collaborator

bretg commented Oct 16, 2019

Merged - thanks @pm-harshad-mane . Also fixing the prebid.org entry, which listed the type of this value as a number rather than a string

@bretg bretg closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants