Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldbot: Multiple requestBids Not Working #481

Closed
ehoch opened this issue Jul 26, 2016 · 7 comments
Closed

Yieldbot: Multiple requestBids Not Working #481

ehoch opened this issue Jul 26, 2016 · 7 comments

Comments

@ehoch
Copy link
Contributor

ehoch commented Jul 26, 2016

So we currently split our ad auctions up amongst our ATF and BTF units and run multiple Prebid auctions. Unfortunately, the Yieldbot adaptor does not work with this.

Easy to replicate. Define two ad units. Run requestBids twice - once the first ad unit and a separate one on the second . Then run yieldbot.dumpLog() in the console.

You'll see that only the initial ad slot that is defined gets a call to getSlotCriteria() with the handleUpdateState() is run. You'll only get bid responses on the initial slots.

@protonate
Copy link
Collaborator

I believe that PR #498 can address this if the Yieldbot adapter can be updated to set the bid response ID to match the bid request ID in these locations:
https://github.com/prebid/Prebid.js/blob/master/src/adapters/yieldbot.js#L51
https://github.com/prebid/Prebid.js/blob/master/src/adapters/yieldbot.js#L70

@mkendall07
Copy link
Member

is this still an issue?

@ehoch
Copy link
Contributor Author

ehoch commented Feb 27, 2017

@mkendall07 Yes unfortunately.

@mkendall07
Copy link
Member

@elljoh @amcmillan01
Either of you want to try and fix this? Been open for a long time.

@elljoh
Copy link
Contributor

elljoh commented Mar 31, 2017

@mkendall07 Yes. Please assign to me.

@CarsonBanov
Copy link
Contributor

@elljoh You might try removing the cache=true flag from the adloader.loadScript call in the adapter and just letting their script load twice.
See:
https://github.com/prebid/Prebid.js/blob/master/src/adapters/yieldbot.js#L110
https://github.com/prebid/Prebid.js/pull/466/files#diff-74a5dc55dc79589eecd119f347c94a28R110

@elljoh
Copy link
Contributor

elljoh commented Apr 17, 2017

We have identified problem and expect to have a PR submitted in the next couple of days to reference a fix for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants