set bid response id to sovrn impid

[protonate]

No description provided.

[protonate]

A further issue arises in the bidmanager.addBidResponse function that causes the first Sovrn bid returned to win the auction.

We assume a single bid per bidder per placement here:
https://github.com/prebid/Prebid.js/blob/accomodate-sovrn-multisize/src/bidmanager.js#L73

I'll push up a commit that will check for the existence of a bidResponse.adId which will now be set by the Sovrn adapter passing a bidObj to the bid factory. If an ID already exists we won't need to do this "best effort" approach in bidmanager.

cc: @pdramos1 @cliffliang

[protonate]

cc: @prebid/sovrn for review

[sovrnoss]

@protonate

We've tested the change and can confirm that the multisize issue is fixed.
The adIds are all unique and the winning bid is selected.

We took a first stab at the unit test for this change. But, we think that it needs to test the bidManager instead of the sovrn Adaptor.

Would you be able to write this test for the updated functionality? Let us know if you need any assistance or have any questions.

Thanks again for all your work here,
sovrn Support Team

[nanek]

Can this be required/implemented for all adapters? This issue is not isolated to Sovrn, it is just potentially more commonly setup there and was noticed first. aardvark and triplelift are two additional examples where we will run into this issue in our current setup as we setup flex sizes for them.

[protonate]

We are working towards this approach as a requirement for adapters but opted not to implement by core team as it became too obtrusive to modify adapter code ourselves.

[nanek]

On L81 in sovrn.js bid = bidfactory.createBid(2); does this need to be updated also? Or will all responses have an adId now, so the "best effort approach" is never called?

[sovrnoss]

@nanek

The best effort approach within the bidmanager is not called in that case. The bid response has an bidId by the time it's added through bidmanager.addBidResponse.

That bidId, however, is randomly generated when the bid is created on L18 of bidfactory.js. In the other case (status 1 bid response) on L122 of sovrn.js, the bidId is created from the original request.

When we tested the empty response case within a test environment, the bidId within the pbjs.adUnits object did not match the adId within the bidResponses object for the empty unit.

We agree with the change suggested above. We don't believe that the case above will create any issues, because the best effort approach isn't called.
But, it seems that the point is to match the original bidIds from the requests to the adIds in the responses. So, for that reason, and for consistency sake, it would be better to update L81 in sovrn.js

Thanks,
sovrn Support Team

[protonate]

@sovrnoss This fix and a test are merged to master and will be included in our next release. Please have a last past and confirm that these changes resolve multi-size functionality for Sovrn adapter.

cc: @cliffliang @pdramos1

[sovrnoss]

We've had an additional quality assurance resource double check and verify the change and have confirmed that the multi-size functionality is resolved.